added log on failure to attach

auth/auth.go

@@ -84,13 +84,13 @@ func (con *AuthApi) LoggedIn(ctx *gin.Context) {
 }
 
 type SignUpRequest struct {
-	Token    string
-	Username string
-	Password string
+	Username string `json:"username"`
+	Password string `json:"password"`
 }
 
 func (con AuthApi) signUp(ctx *gin.Context) {
 	var request SignUpRequest
+	rawToken := ctx.Query("token")
 
 	err := json.NewDecoder(ctx.Request.Body).Decode(&request)
 	if err != nil {
@@ -98,7 +98,7 @@ func (con AuthApi) signUp(ctx *gin.Context) {
 		return
 	}
 
-	token, err := con.tokenHandler.GetInviteToken(ctx, request.Token)
+	token, err := con.tokenHandler.GetInviteToken(ctx, rawToken)
 	if err != nil {
 		ctx.AbortWithError(500, err)
 		return
@@ -110,7 +110,6 @@ func (con AuthApi) signUp(ctx *gin.Context) {
 	}
 
 	err = con.userAuthDbHandler.CreateUser(ctx, request.Username, request.Password, token.Permissions, token.Email, con.config.Users.DefaultMaxOwnedServers)
-
 	if err != nil {
 		ctx.AbortWithError(500, err)
 		return
@@ -120,15 +119,13 @@ func (con AuthApi) signUp(ctx *gin.Context) {
 }
 
 type SignInRequest struct {
-	Username string
-	Password string
+	Username string `json:"username"`
+	Password string `json:"password"`
 }
 
 func (con AuthApi) signIn(ctx *gin.Context) {
-
 	var request SignInRequest
 	err := json.NewDecoder(ctx.Request.Body).Decode(&request)
-
 	if err != nil {
 		ctx.AbortWithError(500, err)
 		return
@@ -159,13 +156,13 @@ func (con AuthApi) Verify(ctx *gin.Context) {
 	claimsPointer, exists := ctx.Get("claims")
 	if !exists {
 		ctx.Status(403)
-		ctx.Error(errors.New("Failed to get claims, not logged in"))
+		ctx.Error(errors.New("failed to get claims, not logged in"))
 		return
 	}
 
 	claims, ok := claimsPointer.(*AuthClaims)
 	if !ok {
-		ctx.Error(errors.New("Failed to convert claims"))
+		ctx.Error(errors.New("failed to convert claims"))
 		ctx.Status(500)
 		return
 	}

config.yaml

@@ -19,8 +19,6 @@ authentication:
   user_pass:
     type: "mongo"
     initial_user:
-      username: ""
-      password: ""
       email: ""
     mongo:
       url: "mongodb://mongo:27107"

dbhandler/mongo/user_pass_authentication.go

@@ -25,9 +25,8 @@ type UserPassAuthenticationDbHandler struct {
 	collection *mongo.Collection
 }
 
-func (self *UserPassAuthenticationDbHandler) ListUsers(ctx context.Context) ([]models.User, error) {
-	cursor, err := self.collection.Find(ctx, bson.M{})
-
+func (i *UserPassAuthenticationDbHandler) ListUsers(ctx context.Context) ([]models.User, error) {
+	cursor, err := i.collection.Find(ctx, bson.M{})
 	if err != nil {
 		return nil, err
 	}
@@ -50,16 +49,14 @@ func (self *UserPassAuthenticationDbHandler) ListUsers(ctx context.Context) ([]m
 	return modelUsers, nil
 }
 
-func (self *UserPassAuthenticationDbHandler) AuthenticateUser(ctx context.Context, username string, password string) (*models.User, error) {
+func (i *UserPassAuthenticationDbHandler) AuthenticateUser(ctx context.Context, username string, password string) (*models.User, error) {
 	var user AuthUser
-	err := self.collection.FindOne(ctx, bson.M{"username": username}).Decode(&user)
-
+	err := i.collection.FindOne(ctx, bson.M{"username": username}).Decode(&user)
 	if err != nil {
 		return nil, err
 	}
 
 	err = bcrypt.CompareHashAndPassword([]byte(user.HashedPassword), []byte(password))
-
 	if err != nil {
 		return nil, err
 	}
@@ -73,7 +70,7 @@ func (self *UserPassAuthenticationDbHandler) AuthenticateUser(ctx context.Contex
 	}, nil
 }
 
-func (self *UserPassAuthenticationDbHandler) CreateUser(
+func (i *UserPassAuthenticationDbHandler) CreateUser(
 	ctx context.Context,
 	username string,
 	password string,
@@ -82,12 +79,11 @@ func (self *UserPassAuthenticationDbHandler) CreateUser(
 	maxOwnedServers uint,
 ) error {
 	hashedPassword, err := dbhandler.HashPassword(password)
-
 	if err != nil {
 		return err
 	}
 
-	_, err = self.collection.InsertOne(ctx, &AuthUser{
+	_, err = i.collection.InsertOne(ctx, &AuthUser{
 		Username:       username,
 		HashedPassword: hashedPassword,
 		Permissions:    permissions,
@@ -98,16 +94,16 @@ func (self *UserPassAuthenticationDbHandler) CreateUser(
 	return err
 }
 
-func (self *UserPassAuthenticationDbHandler) CountUsers(ctx context.Context) (uint, error) {
-	count, err := self.collection.CountDocuments(ctx, bson.M{})
+func (i *UserPassAuthenticationDbHandler) CountUsers(ctx context.Context) (uint, error) {
+	count, err := i.collection.CountDocuments(ctx, bson.M{})
 	if err != nil {
 		return 0, err
 	}
 	return uint(count), nil
 }
 
-func (self *UserPassAuthenticationDbHandler) RemoveUser(ctx context.Context, username string) error {
-	_, err := self.collection.DeleteOne(
+func (i *UserPassAuthenticationDbHandler) RemoveUser(ctx context.Context, username string) error {
+	_, err := i.collection.DeleteOne(
 		ctx,
 		bson.M{
 			"username": username,
@@ -117,12 +113,12 @@ func (self *UserPassAuthenticationDbHandler) RemoveUser(ctx context.Context, use
 	return err
 }
 
-func (self *UserPassAuthenticationDbHandler) SetPermissions(
+func (i *UserPassAuthenticationDbHandler) SetPermissions(
 	ctx context.Context,
 	username string,
 	permissions models.Permission,
 ) error {
-	_, err := self.collection.UpdateOne(
+	_, err := i.collection.UpdateOne(
 		ctx,
 		bson.M{
 			"username": username,
@@ -149,9 +145,9 @@ func NewUserPassAuthHandler(config models.MongoDBConfig) (*UserPassAuthenticatio
 }
 
 type InviteToken struct {
-	Email       string            `json:"email"`
-	Token       string            `json:"token"`
-	Permissions models.Permission `json:"permissions"`
+	Email       string            `bson:"email"`
+	Token       string            `bson:"token"`
+	Permissions models.Permission `bson:"permissions"`
 }
 
 type InviteTokenDbHandler struct {
@@ -159,15 +155,14 @@ type InviteTokenDbHandler struct {
 	collection *mongo.Collection
 }
 
-func (self *ServersDbHandler) SaveInviteToken(ctx context.Context, email string, permissions models.Permission) (string, error) {
+func (i *InviteTokenDbHandler) SaveInviteToken(ctx context.Context, email string, permissions models.Permission) (string, error) {
 	token := uuid.NewString()
 
-	_, err := self.collection.InsertOne(ctx, &InviteToken{
+	_, err := i.collection.InsertOne(ctx, &InviteToken{
 		Permissions: permissions,
 		Email:       email,
 		Token:       token,
 	})
-
 	if err != nil {
 		return "", err
 	}
@@ -175,9 +170,9 @@ func (self *ServersDbHandler) SaveInviteToken(ctx context.Context, email string,
 	return token, nil
 }
 
-func (self *ServersDbHandler) GetInviteToken(ctx context.Context, token string) (*dbhandler.InviteToken, error) {
+func (i *InviteTokenDbHandler) GetInviteToken(ctx context.Context, token string) (*dbhandler.InviteToken, error) {
 	var inviteToken InviteToken
-	err := self.collection.FindOne(ctx, bson.M{"token": token}).Decode(&inviteToken)
+	err := i.collection.FindOne(ctx, bson.M{"token": token}).Decode(&inviteToken)
 	if err != nil {
 		return nil, err
 	}

factories/dbhandlers.go

@@ -1,11 +1,8 @@
 package factories
 
 import (
-	"context"
 	"errors"
-	"log"
 	"sync"
-	"time"
 
 	"git.acooldomain.co/server-manager/backend/dbhandler"
 	"git.acooldomain.co/server-manager/backend/dbhandler/mongo"
@@ -136,21 +133,6 @@ func GetUserPassAuthDbHandler(config models.UserPassAuthConfig) (dbhandler.UserP
 	}
 
 	userPassAuthDbHandlers[key] = handler
-
-	ctx, cancel := context.WithTimeoutCause(context.Background(), 5*time.Second, errors.New("Timeout"))
-	defer cancel()
-	if config.InitialUser == nil {
-		return handler, nil
-	}
-
-	count, _ := handler.CountUsers(ctx)
-	if count == 0 {
-		log.Printf("Trying to create user %#v\n", config.InitialUser)
-		err := handler.CreateUser(ctx, config.InitialUser.Username, config.InitialUser.Password, models.Admin, config.InitialUser.Email, 10)
-		if err != nil {
-			log.Printf("Failed to create initial user %e\n", err)
-		}
-	}
 	return handler, nil
 }
 

instancemanager/kubernetes/instance_manager.go

@@ -3,6 +3,7 @@ package kubernetes
 import (
 	"context"
 	"io"
+	"log"
 	"os"
 	"path/filepath"
 	"strings"
@@ -250,22 +251,24 @@ func (i *InstanceManager) InteractiveTerminal(ctx context.Context, serverId stri
 	req := i.coreV1Cli.CoreV1().RESTClient().
 		Post().
 		Resource("pods").
-		Namespace(i.Config.Namespace).
 		Name(serverId).
+		Namespace(i.Config.Namespace).
 		SubResource("attach").
 		VersionedParams(&corev1.PodAttachOptions{
-			Container: "server",
-			Stdin:     true,
-			Stdout:    true,
-			Stderr:    true,
-			TTY:       true,
+			Stdin:  true,
+			Stdout: true,
+			Stderr: true,
+			TTY:    true,
 		}, clientgoscheme.ParameterCodec)
 
 	executor, err := remotecommand.NewSPDYExecutor(i.restCfg, "POST", req.URL())
 	go func() {
 		defer stdoutWriter.Close()
 		defer stdinReader.Close()
-		_ = executor.StreamWithContext(ctx, remotecommand.StreamOptions{Stdin: stdinReader, Stdout: stdoutWriter, Stderr: stdoutWriter, Tty: true, TerminalSizeQueue: queue})
+		err := executor.StreamWithContext(ctx, remotecommand.StreamOptions{Stdin: stdinReader, Stdout: stdoutWriter, Stderr: stdoutWriter, Tty: true, TerminalSizeQueue: queue})
+		if err != nil {
+			log.Printf("Failed to attach %e", err)
+		}
 	}()
 
 	if err != nil {

mail/mail.go

@@ -22,12 +22,12 @@ func NewMailClient(config models.EmailConfig) *MailClient {
 	}
 }
 
-func (self *MailClient) SendMail(
+func (mc *MailClient) SendMail(
 	recipient string,
 	subject string,
 	content string,
 ) error {
-	from := mail.Address{Name: "", Address: self.mailConfig.FromEmail}
+	from := mail.Address{Name: "", Address: mc.mailConfig.FromEmail}
 	to := mail.Address{Name: "", Address: recipient}
 
 	headers := make(map[string]string)
@@ -41,21 +41,21 @@ func (self *MailClient) SendMail(
 	}
 	message += "\r\n" + content
 
-	conn, err := tls.Dial("tcp", self.mailConfig.Server+":465", &tls.Config{ServerName: self.mailConfig.Server})
+	conn, err := tls.Dial("tcp", mc.mailConfig.Server+":465", &tls.Config{ServerName: mc.mailConfig.Server})
 	if err != nil {
 		return err
 	}
 
-	client, err := smtp.NewClient(conn, self.mailConfig.Server)
+	client, err := smtp.NewClient(conn, mc.mailConfig.Server)
 	if err != nil {
 		return err
 	}
 
-	if err = client.Auth(*self.auth); err != nil {
+	if err = client.Auth(*mc.auth); err != nil {
 		return err
 	}
 
-	if err = client.Mail(self.mailConfig.FromEmail); err != nil {
+	if err = client.Mail(mc.mailConfig.FromEmail); err != nil {
 		return err
 	}
 

main.go

@@ -1,7 +1,6 @@
 package main
 
 import (
-	"fmt"
 	"os"
 
 	"git.acooldomain.co/server-manager/backend/auth"
@@ -21,7 +20,7 @@ func main() {
 	cors_config := cors.DefaultConfig()
 	cors_config.AllowCredentials = true
 	cors_config.ExposeHeaders = []string{"set-cookie"}
-	file, err := os.Open(fmt.Sprintf("%s", os.Getenv(CONFIG_PATH)))
+	file, err := os.Open(os.Getenv(CONFIG_PATH))
 	if err != nil {
 		panic(err)
 	}

models/config.go

@@ -1,9 +1,7 @@
 package models
 
 type InitialUserConfig struct {
-	Email    string `yaml:"email"`
-	Username string `yaml:"username"`
-	Password string `yaml:"password"`
+	Email string `yaml:"email"`
 }
 
 type EmailConfig struct {

users/users.go

@@ -1,8 +1,12 @@
 package users
 
 import (
+	"context"
 	"encoding/json"
+	"errors"
+	"log"
 	"net/http"
+	"time"
 
 	"git.acooldomain.co/server-manager/backend/auth"
 	"git.acooldomain.co/server-manager/backend/dbhandler"
@@ -28,7 +32,6 @@ type UserResponse struct {
 
 func (con UsersApi) GetUsers(ctx *gin.Context) {
 	users, err := con.userPassAuthHandler.ListUsers(ctx)
-
 	if err != nil {
 		ctx.AbortWithError(500, err)
 		return
@@ -65,18 +68,24 @@ type InviteUser struct {
 	Permissions models.Permission `json:"Permissions"`
 }
 
+func (con *UsersApi) inviteUser(ctx context.Context, email string, permissions models.Permission) error {
+	token, err := con.tokenHandler.SaveInviteToken(ctx, email, permissions)
+	if err != nil {
+		return err
+	}
+
+	err = con.mailClient.SendMail(email, "You've been invited to join", "please open this link https://games.acooldomain.co/signup?token="+token)
+	if err != nil {
+		return err
+	}
+
+	return nil
+}
+
 func (con UsersApi) InviteUser(ctx *gin.Context) {
 	var request InviteUser
 	json.NewDecoder(ctx.Request.Body).Decode(&request)
-
-	token, err := con.tokenHandler.SaveInviteToken(ctx, request.Email, request.Permissions)
-
-	if err != nil {
-		ctx.AbortWithError(500, err)
-		return
-	}
-
-	err = con.mailClient.SendMail(request.Email, "You've been invited to join", "please open this link https://games.acooldomain.co/signup?token="+token)
+	err := con.inviteUser(ctx, request.Email, request.Permissions)
 	if err != nil {
 		ctx.AbortWithError(500, err)
 		return
@@ -107,7 +116,6 @@ func (con UsersApi) DeleteUser(ctx *gin.Context) {
 	username := ctx.Param("user_id")
 
 	err := con.userPassAuthHandler.RemoveUser(ctx, username)
-
 	if err != nil {
 		ctx.AbortWithError(500, err)
 		return
@@ -123,6 +131,9 @@ func LoadGroup(group *gin.RouterGroup, config models.GlobalConfig) {
 	}
 
 	inviteHandler, err := factories.GetInviteTokenDbHandler(config.Authentication.UserPass.InviteTokenDatabase)
+	if err != nil {
+		panic(err)
+	}
 
 	mailClient := *mail.NewMailClient(config.Email)
 
@@ -133,6 +144,20 @@ func LoadGroup(group *gin.RouterGroup, config models.GlobalConfig) {
 		config:              &config,
 	}
 
+	if config.Authentication.Type == models.UserPass && config.Authentication.UserPass.InitialUser != nil {
+		ctx, cancel := context.WithTimeoutCause(context.Background(), 5*time.Second, errors.New("Timeout"))
+		defer cancel()
+
+		count, _ := connection.userPassAuthHandler.CountUsers(ctx)
+		if count == 0 {
+			log.Printf("Trying to create user %#v\n", config.Authentication.UserPass.InitialUser)
+			err := connection.inviteUser(ctx, config.Authentication.UserPass.InitialUser.Email, models.Admin)
+			if err != nil {
+				log.Printf("Failed to create initial user %e\n", err)
+			}
+		}
+	}
+
 	group.GET("", auth.AuthorizedTo(0), auth.AuthorizationEnforcer(), connection.GetUsers)
 	group.GET("/@me", auth.AuthorizedTo(0), auth.AuthorizationEnforcer(), connection.GetUser)
 	group.POST("", auth.AuthorizedTo(models.Admin), auth.AuthorizationEnforcer(), connection.InviteUser)