22bfd0c83e
fix: format of date when MR was closed or merged (#367) refactor: Add Payload Validators + Middleware In Go Code (#366) fix: Add better checks for leaving comments (#369) fix: regex support for http credentials embedded in remote url (#372) fix: Comment on single line selects two lines (#371) This is a #PATCH release.
60 lines
2.0 KiB
Go
60 lines
2.0 KiB
Go
package app
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/xanzy/go-gitlab"
|
|
)
|
|
|
|
type fakeReplyManager struct {
|
|
testBase
|
|
}
|
|
|
|
func (f fakeReplyManager) AddMergeRequestDiscussionNote(interface{}, int, string, *gitlab.AddMergeRequestDiscussionNoteOptions, ...gitlab.RequestOptionFunc) (*gitlab.Note, *gitlab.Response, error) {
|
|
resp, err := f.handleGitlabError()
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
|
|
return &gitlab.Note{}, resp, err
|
|
}
|
|
|
|
func TestReplyHandler(t *testing.T) {
|
|
var testReplyRequest = ReplyRequest{DiscussionId: "abc123", Reply: "Some Reply", IsDraft: false}
|
|
t.Run("Sends a reply", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPost, "/mr/reply", testReplyRequest)
|
|
svc := middleware(
|
|
replyService{testProjectData, fakeReplyManager{}},
|
|
withMr(testProjectData, fakeMergeRequestLister{}),
|
|
withPayloadValidation(methodToPayload{http.MethodPost: &ReplyRequest{}}),
|
|
withMethodCheck(http.MethodPost),
|
|
)
|
|
data := getSuccessData(t, svc, request)
|
|
assert(t, data.Message, "Replied to comment")
|
|
})
|
|
t.Run("Handles errors from Gitlab client", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPost, "/mr/reply", testReplyRequest)
|
|
svc := middleware(
|
|
replyService{testProjectData, fakeReplyManager{testBase{errFromGitlab: true}}},
|
|
withMr(testProjectData, fakeMergeRequestLister{}),
|
|
withPayloadValidation(methodToPayload{http.MethodPost: &ReplyRequest{}}),
|
|
withMethodCheck(http.MethodPost),
|
|
)
|
|
data, _ := getFailData(t, svc, request)
|
|
checkErrorFromGitlab(t, data, "Could not leave reply")
|
|
})
|
|
|
|
t.Run("Handles non-200s from Gitlab client", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPost, "/mr/reply", testReplyRequest)
|
|
svc := middleware(
|
|
replyService{testProjectData, fakeReplyManager{testBase{status: http.StatusSeeOther}}},
|
|
withMr(testProjectData, fakeMergeRequestLister{}),
|
|
withPayloadValidation(methodToPayload{http.MethodPost: &ReplyRequest{}}),
|
|
withMethodCheck(http.MethodPost),
|
|
)
|
|
data, _ := getFailData(t, svc, request)
|
|
checkNon200(t, data, "Could not leave reply", "/mr/reply")
|
|
})
|
|
}
|