22bfd0c83e
fix: format of date when MR was closed or merged (#367) refactor: Add Payload Validators + Middleware In Go Code (#366) fix: Add better checks for leaving comments (#369) fix: regex support for http credentials embedded in remote url (#372) fix: Comment on single line selects two lines (#371) This is a #PATCH release.
59 lines
1.9 KiB
Go
59 lines
1.9 KiB
Go
package app
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/xanzy/go-gitlab"
|
|
)
|
|
|
|
type fakeApproverClient struct {
|
|
testBase
|
|
}
|
|
|
|
func (f fakeApproverClient) ApproveMergeRequest(pid interface{}, mr int, opt *gitlab.ApproveMergeRequestOptions, options ...gitlab.RequestOptionFunc) (*gitlab.MergeRequestApprovals, *gitlab.Response, error) {
|
|
resp, err := f.handleGitlabError()
|
|
if err != nil {
|
|
return nil, nil, err
|
|
}
|
|
return &gitlab.MergeRequestApprovals{}, resp, nil
|
|
}
|
|
|
|
func TestApproveHandler(t *testing.T) {
|
|
t.Run("Approves merge request", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPost, "/mr/approve", nil)
|
|
client := fakeApproverClient{}
|
|
svc := middleware(
|
|
mergeRequestApproverService{testProjectData, client},
|
|
withMr(testProjectData, fakeMergeRequestLister{}),
|
|
withMethodCheck(http.MethodPost),
|
|
)
|
|
data := getSuccessData(t, svc, request)
|
|
assert(t, data.Message, "Approved MR")
|
|
})
|
|
|
|
t.Run("Handles errors from Gitlab client", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPost, "/mr/approve", nil)
|
|
client := fakeApproverClient{testBase{errFromGitlab: true}}
|
|
svc := middleware(
|
|
mergeRequestApproverService{testProjectData, client},
|
|
withMr(testProjectData, fakeMergeRequestLister{}),
|
|
withMethodCheck(http.MethodPost),
|
|
)
|
|
data, _ := getFailData(t, svc, request)
|
|
checkErrorFromGitlab(t, data, "Could not approve merge request")
|
|
})
|
|
|
|
t.Run("Handles non-200s from Gitlab client", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPost, "/mr/approve", nil)
|
|
client := fakeApproverClient{testBase{status: http.StatusSeeOther}}
|
|
svc := middleware(
|
|
mergeRequestApproverService{testProjectData, client},
|
|
withMr(testProjectData, fakeMergeRequestLister{}),
|
|
withMethodCheck(http.MethodPost),
|
|
)
|
|
data, _ := getFailData(t, svc, request)
|
|
checkNon200(t, data, "Could not approve merge request", "/mr/approve")
|
|
})
|
|
}
|