cf6ccddce3
* feat: Support for custom authentication provider functions (#270) * feat: Support for adding "draft" notes to the review, and publishing them, either individually or all at once. Addresses feature request #223. * feat: Lets users select + checkout a merge request directly within Neovim, without exiting to the terminal * fix: Checks that the remote feature branch exists and is up-to-date before creating a MR, starting a review, or opening the MR summary (#278) * docs: We require some state from Diffview, this shows how to load that state prior to installing w/ Packer. Fixes #94. This is a #MINOR release. --------- Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me> Co-authored-by: sunfuze <sunfuze.1989@gmail.com> Co-authored-by: Patrick Pichler <mail@patrickpichler.dev>
59 lines
2.7 KiB
Go
59 lines
2.7 KiB
Go
package main
|
|
|
|
import (
|
|
"errors"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/xanzy/go-gitlab"
|
|
)
|
|
|
|
func updateAssignees(pid interface{}, mergeRequest int, opt *gitlab.UpdateMergeRequestOptions, options ...gitlab.RequestOptionFunc) (*gitlab.MergeRequest, *gitlab.Response, error) {
|
|
return &gitlab.MergeRequest{}, makeResponse(http.StatusOK), nil
|
|
}
|
|
|
|
func updateAssigneesNon200(pid interface{}, mergeRequest int, opt *gitlab.UpdateMergeRequestOptions, options ...gitlab.RequestOptionFunc) (*gitlab.MergeRequest, *gitlab.Response, error) {
|
|
return nil, makeResponse(http.StatusSeeOther), nil
|
|
}
|
|
|
|
func updateAssigneesErr(pid interface{}, mergeRequest int, opt *gitlab.UpdateMergeRequestOptions, options ...gitlab.RequestOptionFunc) (*gitlab.MergeRequest, *gitlab.Response, error) {
|
|
return nil, nil, errors.New("Some error from Gitlab")
|
|
}
|
|
|
|
func TestAssigneeHandler(t *testing.T) {
|
|
t.Run("Updates assignees", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPut, "/mr/assignee", AssigneeUpdateRequest{Ids: []int{1, 2}})
|
|
server, _ := createRouterAndApi(fakeClient{updateMergeRequest: updateAssignees})
|
|
data := serveRequest(t, server, request, AssigneeUpdateResponse{})
|
|
assert(t, data.SuccessResponse.Message, "Assignees updated")
|
|
assert(t, data.SuccessResponse.Status, http.StatusOK)
|
|
})
|
|
|
|
t.Run("Disallows non-PUT method", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPost, "/mr/assignee", nil)
|
|
server, _ := createRouterAndApi(fakeClient{updateMergeRequest: updateAssignees})
|
|
data := serveRequest(t, server, request, ErrorResponse{})
|
|
assert(t, data.Status, http.StatusMethodNotAllowed)
|
|
assert(t, data.Details, "Invalid request type")
|
|
assert(t, data.Message, "Expected PUT")
|
|
})
|
|
|
|
t.Run("Handles errors from Gitlab client", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPut, "/mr/assignee", AssigneeUpdateRequest{Ids: []int{1, 2}})
|
|
server, _ := createRouterAndApi(fakeClient{updateMergeRequest: updateAssigneesErr})
|
|
data := serveRequest(t, server, request, ErrorResponse{})
|
|
assert(t, data.Status, http.StatusInternalServerError)
|
|
assert(t, data.Message, "Could not modify merge request assignees")
|
|
assert(t, data.Details, "Some error from Gitlab")
|
|
})
|
|
|
|
t.Run("Handles non-200s from Gitlab client", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPut, "/mr/assignee", AssigneeUpdateRequest{Ids: []int{1, 2}})
|
|
server, _ := createRouterAndApi(fakeClient{updateMergeRequest: updateAssigneesNon200})
|
|
data := serveRequest(t, server, request, ErrorResponse{})
|
|
assert(t, data.Status, http.StatusSeeOther)
|
|
assert(t, data.Message, "Could not modify merge request assignees")
|
|
assert(t, data.Details, "An error occurred on the /mr/assignee endpoint")
|
|
})
|
|
}
|