93fe3e8bd6
This MR represents a major refactor of the Go codebase, as well as introducing tests for the handlers. The MR also introduces an endpoint to shutdown or restart the Go server, which may be useful for clients who want to refresh the state of the plugin after checking out branches. Finally, this MR adds a contributing document for users who want to make feature changes.
54 lines
2.2 KiB
Go
54 lines
2.2 KiB
Go
package main
|
|
|
|
import (
|
|
"errors"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/xanzy/go-gitlab"
|
|
)
|
|
|
|
func getInfo(pid interface{}, mergeRequest int, opt *gitlab.GetMergeRequestsOptions, options ...gitlab.RequestOptionFunc) (*gitlab.MergeRequest, *gitlab.Response, error) {
|
|
return &gitlab.MergeRequest{Title: "Some Title"}, makeResponse(http.StatusOK), nil
|
|
}
|
|
|
|
func getInfoNon200(pid interface{}, mergeRequest int, opt *gitlab.GetMergeRequestsOptions, options ...gitlab.RequestOptionFunc) (*gitlab.MergeRequest, *gitlab.Response, error) {
|
|
return nil, makeResponse(http.StatusSeeOther), nil
|
|
}
|
|
|
|
func getInfoErr(pid interface{}, mergeRequest int, opt *gitlab.GetMergeRequestsOptions, options ...gitlab.RequestOptionFunc) (*gitlab.MergeRequest, *gitlab.Response, error) {
|
|
return nil, nil, errors.New("Some error from Gitlab")
|
|
}
|
|
|
|
func TestInfoHandler(t *testing.T) {
|
|
t.Run("Returns normal information", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodGet, "/info", nil)
|
|
server, _ := createRouterAndApi(fakeClient{getMergeRequestFn: getInfo})
|
|
data := serveRequest(t, server, request, InfoResponse{})
|
|
assert(t, data.Info.Title, "Some Title")
|
|
assert(t, data.SuccessResponse.Message, "Merge requests retrieved")
|
|
assert(t, data.SuccessResponse.Status, http.StatusOK)
|
|
})
|
|
|
|
t.Run("Disallows non-GET method", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPost, "/info", nil)
|
|
server, _ := createRouterAndApi(fakeClient{getMergeRequestFn: getInfo})
|
|
data := serveRequest(t, server, request, ErrorResponse{})
|
|
checkBadMethod(t, *data, http.MethodGet)
|
|
})
|
|
|
|
t.Run("Handles errors from Gitlab client", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodGet, "/info", nil)
|
|
server, _ := createRouterAndApi(fakeClient{getMergeRequestFn: getInfoErr})
|
|
data := serveRequest(t, server, request, ErrorResponse{})
|
|
checkErrorFromGitlab(t, *data, "Could not get project info")
|
|
})
|
|
|
|
t.Run("Handles non-200s from Gitlab client", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodGet, "/info", nil)
|
|
server, _ := createRouterAndApi(fakeClient{getMergeRequestFn: getInfoNon200})
|
|
data := serveRequest(t, server, request, ErrorResponse{})
|
|
checkNon200(t, *data, "Could not get project info", "/info")
|
|
})
|
|
}
|