Some (like editing the title and description) need the popup text and
should execute prior to closure. This is now configurable via an options
table that can be passed to the set_popup_keymaps function.
This plugin previously only supported the Delta reviewer. Thanks to work
from @mrparalon it now supports Diffview also. This MR adjusts the
requirements to account for this, and the README.
It also addresses a small bug in the original implementation regarding
an async file opening action, and applies formatting to the diffview
file consistent with the rest of the project
We need to rebuild the binary whenever the plugin has changed.
Previously we were not doing this if the binary already existed. This MR
adds an override parameter to the build() function which will force a
rebuild even if the binary already exists.
The README has been updated to note that this parameter should be used
for Packer/Lazy, and when someone is troubleshooting. It won't be passed
in to the build function during the normal setup call.
Should address #55
Previously, the merge function would override the entire default table during a
merge if a matching table was found in the override table.
This would prevent users from modifying a single setting (for instance changing
just a single icon, rather than the whole thing)
This MR improves the configurability of the plugin by using Nui's split
system rather than managing the splits ourselves. This lets the user
configure both the positioning of the discussion tree and it's width,
and reduces overall maintenance of split management for the plugin.
This ensures that the state for the plugin has been initialized prior to
calling any of the other jobs. This ensures that they won't error if
called quickly after Neovim starts up
This should hopefully make it easier to debug and for users to figure
out what's going on by exposing the state of the plugin.
It is a Lua table, and can be seen via `:lua print(require("gitlab").state)`
The easiest way to print out a Lua table is with some sort of utility
function like this:
```
function printTable(...)
local objects = {}
for i = 1, select("#", ...) do
local v = select(i, ...)
table.insert(objects, vim.inspect(v))
end
print(table.concat(objects, "\n"))
return ...
end
```
added a new file
First major commit
Successful POST of new comment 🚀
Updated README
Updated README 📕
Added more infrastructure
Creating async job
More setup
Getting arguments from Neovim -> Lua -> Golang
Moved commands
Added getProjectInfo command
Adding make comment command
Setting up arguments for MakeComment command
Removed extraneous comments
Setup basic function for adding comments
Lint fixes
Handling bad requests correctly
Better formatting
Printing success message
Adding utility table print
Set comment from popup UI
Added mappings for closing and sending text
Moved popup into separate file
Added comment
Cleaned up code and added approve command
Initialize project information
Removed extraneous import
Don't initialize project in non-gitlab directories
Setup approve command
Set up revoke and approve commands correctly
Cleaned up redundant code
Moved get current branch command
Reorganization of the code
First attempt to add step installing Go binary
Adjusted path to binary
Added install bin check
Do Lua method
Fixed install step
Tweaked binPath + bin
Added basic readme information 📗
Removed .luarc.json file
Adding diffview command
Added string_starts function
Made base branch configurable
Added note to readme
Fixed readme
Added diffview dep to readme
Update README.md
Update README.md
Update README.md
Update README.md
Renamed files
Set up developer workflow
Updated README
Removed dev note
Refactor and moving around files
Fixed ft/after mappings
Setup read command
Added read summary command
Got rid of filetype bindings and set up commands
Set correct filetype for comment buffer
Added read() command to README
Updated review -> summary
Fixed issue with diffview buffers
Added command for getting and showing all comments (out of order)
Better error message
Adding more code to handle showing comments
Added ability to jump from comment to specific changed buffer line
Initial refactor
Added simple comment action
Fixed error message
More cleanup
Fixed bug with M.PROJECT_ID
Leaving comment refactor
Fixed comment
Cleaned up old code
Added missing exit command
Check gitlab repo status before initialization
Better help strings
Added ListDiscussions command
Added Go code
Darkened metadata, filtered out non-real discussions
Removed dummy log
Sort the discussions by most recent activity
Grab hash of current discussion
Wired up reply action in Lua code
Moved to NUI Table
Adding basic jump-to-file ability
More tweaks
Allow jump anywhere in the tree
Ability to reply directly in the buffer window
Jump to location in file
Don't jump if no refresh is set
Cleaned up mappings + other code
Get rid of gitlab CLI dependency
Fixed discussions bug
Don't initialize client on main/master branches
Moved comment into separate module
Moved lua modules into separate files
Modularized library and state
Slightly better error/exception handling
Added license file
Updated readme
Moved into todo.md file
Added todo file
Standardized naming conventions (snake_case in Lua, camelCase in Go)
Moved common popup state into utils folder
Cleaned up keymapping functions
Note on install
Changing bin path
Updated README
Chnaged from success to info
Redirect output to /dev/null on build
Checking install code
Removed print statement
Slight reorganization
Setting up delete comment
Set up confirmation modal
Passing in node ID to delete_comment
Functioning comment deletion
Added delete_comment command
Updated README
Furhter modularized discussion code
Cleaned up and refactored reply code
Update README.md
Added ability to edit comments
Updated todos
Fixed main/master base branch issue
Set up keybinding rules
Updated todo.md
Removed diffview dependency
Slight cleanup 🧹
Trying something out...
Trying something for the binary...
Trying again
Fixed install for non-lazy users
Update README.md
Update README.md
Update README.md
Update README.md
Update README.md
Harrison Cramer