guill
2b653e8c18
Support for async node functions ( #8830 )
...
* Support for async execution functions
This commit adds support for node execution functions defined as async. When
a node's execution function is defined as async, we can continue
executing other nodes while it is processing.
Standard uses of `await` should "just work", but people will still have
to be careful if they spawn actual threads. Because torch doesn't really
have async/await versions of functions, this won't particularly help
with most locally-executing nodes, but it does work for e.g. web
requests to other machines.
In addition to the execute function, the `VALIDATE_INPUTS` and
`check_lazy_status` functions can also be defined as async, though we'll
only resolve one node at a time right now for those.
* Add the execution model tests to CI
* Add a missing file
It looks like this got caught by .gitignore? There's probably a better
place to put it, but I'm not sure what that is.
* Add the websocket library for automated tests
* Add additional tests for async error cases
Also fixes one bug that was found when an async function throws an error
after being scheduled on a task.
* Add a feature flags message to reduce bandwidth
We now only send 1 preview message of the latest type the client can
support.
We'll add a console warning when the client fails to send a feature
flags message at some point in the future.
* Add async tests to CI
* Don't actually add new tests in this PR
Will do it in a separate PR
* Resolve unit test in GPU-less runner
* Just remove the tests that GHA can't handle
* Change line endings to UNIX-style
* Avoid loading model_management.py so early
Because model_management.py has a top-level `logging.info`, we have to
be careful not to import that file before we call `setup_logging`. If we
do, we end up having the default logging handler registered in addition
to our custom one.
2025-07-10 14:46:19 -04:00
kosinkadink1@gmail.com
5ee63e284b
Renamed 'node' to 'cls' in PreviewImage/Mask
2025-07-10 01:53:27 -05:00
kosinkadink1@gmail.com
5423a4f262
Made id on static Outputs optional, still required on DynamicOutput
2025-07-10 01:49:01 -05:00
kosinkadink1@gmail.com
fe2cadeaa0
Remove input display_names on nodes where the inputs already have the desired name via id
2025-07-10 01:25:07 -05:00
kosinkadink1@gmail.com
2b5bd2ace3
Set widgetType only when doing MultiType
2025-07-10 01:24:17 -05:00
Jedrzej Kosinski
19bb231fbd
Merge pull request #8833 from bigcat88/v3-load-save-nodes-replacement
...
[v3] Migrate LoadImage and SaveImage nodes to v3 schema
2025-07-09 22:20:17 -07:00
comfyanonymous
1fd306824d
Add warning to catch torch import mistakes. ( #8852 )
2025-07-10 01:03:27 -04:00
bigcat88
d8b91bb84e
put V1 nodes back
2025-07-10 07:58:34 +03:00
bigcat88
965d2f9b8f
use options key, remove get_io_type_V1 serialization
2025-07-10 06:47:52 +03:00
Jedrzej Kosinski
7521ff7dad
Merge pull request #8850 from comfyanonymous/v3-definition-wip
...
Fixed missing comma in init_builtin_extra_nodes after merge
2025-07-09 20:47:27 -07:00
kosinkadink1@gmail.com
a6bcb184f6
Fixed missing comma in init_builtin_extra_nodes after merge
2025-07-09 22:46:22 -05:00
bigcat88
e1975567a3
removed widgetType from serialization
2025-07-10 06:38:49 +03:00
bigcat88
982f4d6f31
removed "prepare_class_clone" modification
2025-07-10 04:36:17 +03:00
Kohaku-Blueleaf
1205afc708
Better training loop implementation ( #8820 )
2025-07-09 11:41:22 -04:00
bigcat88
8f0621ca7e
IS_CHANGED->fingerprint_inputs , VALIDATE_INPUTS->validate_inputs
2025-07-09 14:02:28 +03:00
bigcat88
fefb24cc33
fixes, corrections; ported MaskPreview, WebcamCapture and LoadImageOutput nodes
2025-07-09 13:37:57 +03:00
bigcat88
1eb1a44883
migrate PreviewImage node to V3
2025-07-09 13:37:57 +03:00
bigcat88
36770c1658
migrate load and save images nodes to v3 schema (rebased)
2025-07-09 13:37:44 +03:00
kosinkadink1@gmail.com
5f91e2905a
Merge branch 'v3-definition' of https://github.com/comfyanonymous/ComfyUI into v3-definition
2025-07-09 03:58:16 -05:00
kosinkadink1@gmail.com
3aa2d19c70
Merge branch 'master' into v3-definition
2025-07-09 03:58:09 -05:00
Jedrzej Kosinski
2b9ff52248
Merge pull request #8846 from comfyanonymous/v3-definition-wip
...
V3 definition update - misc fixes, function additions, and dynamic inputs mock
2025-07-09 01:56:35 -07:00
kosinkadink1@gmail.com
cc68880914
Moved force_input arg to be before extra_dict to fix
2025-07-09 03:44:37 -05:00
kosinkadink1@gmail.com
904dc06451
Add force_input support to certain WidgetInputV3 inputs
2025-07-09 03:38:50 -05:00
kosinkadink1@gmail.com
56ccfeaa8a
Add fingerprint_inputs support (V3's IS_CHANGED)
2025-07-09 03:25:23 -05:00
comfyanonymous
5612670ee4
Remove unmaintained notebook. ( #8845 )
2025-07-09 03:45:48 -04:00
kosinkadink1@gmail.com
82e6eeab75
Support validate_inputs for v3 replacing VALIDATE_INPUTS, support check_lazy_mix for v3, prep for renaming IS_CHANGED to fingerprint_inputs, reorder some class methods
2025-07-09 02:26:35 -05:00
kosinkadink1@gmail.com
936bf6b60f
Add metadata to image previews, add a finalize function on SchemaV3 to automatically add hidden values that are required by certain toggles on node definition
2025-07-09 01:09:18 -05:00
kosinkadink1@gmail.com
a86fddcdd4
Fixed MultiCombo, confirmed VALIDATE_INPUTS, IS_CHANGED works
2025-07-09 00:26:15 -05:00
Kohaku-Blueleaf
181a9bf26d
Support Multi Image-Caption dataset in lora training node ( #8819 )
...
* initial impl of multi img/text dataset
* Update nodes_train.py
* Support Kohya-ss structure
2025-07-08 20:18:04 -04:00
chaObserv
aac10ad23a
Add SA-Solver sampler ( #8834 )
2025-07-08 16:17:06 -04:00
josephrocca
974254218a
Un-hardcode chroma patch_size ( #8840 )
2025-07-08 15:56:59 -04:00
comfyanonymous
c5de4955bb
ComfyUI version 0.3.44
2025-07-08 08:56:38 -04:00
Christian Byrne
9fd0cd7cf7
Add Moonvalley nodes ( #8832 )
2025-07-08 08:54:30 -04:00
ComfyUI Wiki
b5e97db9ac
Update template to 0.1.35 ( #8831 )
2025-07-08 08:52:02 -04:00
Christian Byrne
1359c969e4
Update template to 0.1.34 ( #8829 )
2025-07-07 23:35:41 -04:00
ComfyUI Wiki
059cd38aa2
Update template and node docs package version ( #8825 )
2025-07-07 20:43:56 -04:00
comfyanonymous
e740dfd806
Fix warning in audio save nodes. ( #8818 )
2025-07-07 03:16:00 -04:00
comfyanonymous
7eab7d2944
Remove dependency on deprecated torchaudio.save function ( #8815 )
2025-07-06 14:01:32 -04:00
comfyanonymous
75d327abd5
Remove some useless code. ( #8812 )
2025-07-06 07:07:39 -04:00
comfyanonymous
ee615ac269
Add warning when loading file unsafely. ( #8800 )
2025-07-05 14:34:57 -04:00
Jedrzej Kosinski
18a7207ca4
Mock AutogrowDynamic type
2025-07-04 16:27:03 -05:00
comfyanonymous
27870ec3c3
Add that ckpt files are loaded safely to README. ( #8791 )
2025-07-04 04:49:11 -04:00
chaObserv
f41f323c52
Add the denoising step to several samplers ( #8780 )
2025-07-03 19:20:53 -04:00
comfyanonymous
f74fc4d927
Add ImageRotate and ImageFlip nodes. ( #8789 )
2025-07-03 19:16:30 -04:00
ComfyUI Wiki
ae26cd99b5
Update template to 0.1.32 ( #8782 )
2025-07-03 14:41:16 -04:00
comfyanonymous
e9af97ba1a
Use torch cu129 for nvidia pytorch nightly. ( #8786 )
...
* update nightly workflow with cu129
* Remove unused file to lower standalone size.
2025-07-03 14:39:11 -04:00
City
d9277301d2
Initial code for new SLG node ( #8759 )
2025-07-02 20:13:43 -04:00
comfyanonymous
34c8eeec06
Fix ImageColorToMask not returning right mask values. ( #8771 )
2025-07-02 15:35:11 -04:00
Harel Cain
9f1069290c
nodes_lt: fixes to latent conditioning at index > 0 ( #8769 )
2025-07-02 15:34:51 -04:00
comfyanonymous
111f583e00
Fallback to regular op when fp8 op throws exception. ( #8761 )
2025-07-02 00:57:13 -04:00
