From b5d606497494bcb1c58c8ea5243347db9678827a Mon Sep 17 00:00:00 2001
From: bymyself <cbyrne@comfy.org>
Date: Mon, 14 Jul 2025 15:32:07 -0700
Subject: [PATCH] [openapi] Add missing /api/features endpoint and improve
 schema organization

- Add /api/features endpoint with ServerFeatures response schema
- Replace inline objects in /internal/logs/raw with RawLogsResponse schema
- Add LogEntry and TerminalSize component schemas for better reusability
- Replace inline LogsSubscribeRequest object with proper schema component
- Add required field constraints to LogsSubscribeRequest

This addresses the missing features endpoint and improves schema
consistency by moving complex inline objects to reusable components.
---
 openapi.yaml | 94 +++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 64 insertions(+), 30 deletions(-)

diff --git a/openapi.yaml b/openapi.yaml
index 0e05037b8..464c0e55a 100644
--- a/openapi.yaml
+++ b/openapi.yaml
@@ -517,6 +517,20 @@ paths:
       responses:
         '101':
           description: Switching Protocols to WebSocket
+  /api/features:
+    get:
+      tags:
+      - system
+      summary: Get server feature flags
+      description: Returns the server's feature flags and capabilities
+      operationId: getFeatures
+      responses:
+        '200':
+          description: Success
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/ServerFeatures'
   /internal/logs:
     get:
       tags:
@@ -544,28 +558,7 @@ paths:
           content:
             application/json:
               schema:
-                type: object
-                properties:
-                  entries:
-                    type: array
-                    items:
-                      type: object
-                      properties:
-                        t:
-                          type: string
-                          description: Timestamp
-                        m:
-                          type: string
-                          description: Message
-                  size:
-                    type: object
-                    properties:
-                      cols:
-                        type: integer
-                        description: Terminal columns
-                      rows:
-                        type: integer
-                        description: Terminal rows
+                $ref: '#/components/schemas/RawLogsResponse'
   /internal/logs/subscribe:
     patch:
       tags:
@@ -578,14 +571,7 @@ paths:
         content:
           application/json:
             schema:
-              type: object
-              properties:
-                clientId:
-                  type: string
-                  description: Client ID
-                enabled:
-                  type: boolean
-                  description: Whether to enable or disable subscription
+              $ref: '#/components/schemas/LogsSubscribeRequest'
       responses:
         '200':
           description: Success
@@ -902,3 +888,51 @@ components:
         type:
           type: string
           description: Type of directory the file was stored in
+    ServerFeatures:
+      type: object
+      properties:
+        supports_preview_metadata:
+          type: boolean
+          description: Whether the server supports preview metadata
+        max_upload_size:
+          type: integer
+          description: Maximum file upload size in bytes
+    RawLogsResponse:
+      type: object
+      properties:
+        entries:
+          type: array
+          items:
+            $ref: '#/components/schemas/LogEntry'
+        size:
+          $ref: '#/components/schemas/TerminalSize'
+    LogEntry:
+      type: object
+      properties:
+        t:
+          type: string
+          description: Timestamp
+        m:
+          type: string
+          description: Message
+    TerminalSize:
+      type: object
+      properties:
+        cols:
+          type: integer
+          description: Terminal columns
+        rows:
+          type: integer
+          description: Terminal rows
+    LogsSubscribeRequest:
+      type: object
+      required:
+        - clientId
+        - enabled
+      properties:
+        clientId:
+          type: string
+          description: Client ID
+        enabled:
+          type: boolean
+          description: Whether to enable or disable subscription