fix: format of date when MR was closed or merged (#367) refactor: Add Payload Validators + Middleware In Go Code (#366) fix: Add better checks for leaving comments (#369) fix: regex support for http credentials embedded in remote url (#372) fix: Comment on single line selects two lines (#371) This is a #PATCH release.
72 lines
2.9 KiB
Go
72 lines
2.9 KiB
Go
package app
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/xanzy/go-gitlab"
|
|
)
|
|
|
|
type fakeDraftNotePublisher struct {
|
|
testBase
|
|
}
|
|
|
|
func (f fakeDraftNotePublisher) PublishAllDraftNotes(pid interface{}, mergeRequest int, options ...gitlab.RequestOptionFunc) (*gitlab.Response, error) {
|
|
return f.handleGitlabError()
|
|
}
|
|
func (f fakeDraftNotePublisher) PublishDraftNote(pid interface{}, mergeRequest int, note int, options ...gitlab.RequestOptionFunc) (*gitlab.Response, error) {
|
|
return f.handleGitlabError()
|
|
}
|
|
|
|
func TestPublishDraftNote(t *testing.T) {
|
|
var testDraftNotePublishRequest = DraftNotePublishRequest{Note: 3}
|
|
t.Run("Publishes draft note", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPost, "/mr/draft_notes/publish", testDraftNotePublishRequest)
|
|
svc := middleware(
|
|
draftNotePublisherService{testProjectData, fakeDraftNotePublisher{}},
|
|
withMr(testProjectData, fakeMergeRequestLister{}),
|
|
withPayloadValidation(methodToPayload{http.MethodPost: &DraftNotePublishRequest{}}),
|
|
withMethodCheck(http.MethodPost),
|
|
)
|
|
data := getSuccessData(t, svc, request)
|
|
assert(t, data.Message, "Draft note(s) published")
|
|
})
|
|
t.Run("Handles error from Gitlab", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPost, "/mr/draft_notes/publish", testDraftNotePublishRequest)
|
|
svc := middleware(
|
|
draftNotePublisherService{testProjectData, fakeDraftNotePublisher{testBase: testBase{errFromGitlab: true}}},
|
|
withMr(testProjectData, fakeMergeRequestLister{}),
|
|
withPayloadValidation(methodToPayload{http.MethodPost: &DraftNotePublishRequest{}}),
|
|
withMethodCheck(http.MethodPost),
|
|
)
|
|
data, _ := getFailData(t, svc, request)
|
|
checkErrorFromGitlab(t, data, "Could not publish draft note(s)")
|
|
})
|
|
}
|
|
|
|
func TestPublishAllDraftNotes(t *testing.T) {
|
|
var testDraftNotePublishRequest = DraftNotePublishRequest{}
|
|
t.Run("Should publish all draft notes", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPost, "/mr/draft_notes/publish", testDraftNotePublishRequest)
|
|
svc := middleware(
|
|
draftNotePublisherService{testProjectData, fakeDraftNotePublisher{}},
|
|
withMr(testProjectData, fakeMergeRequestLister{}),
|
|
withPayloadValidation(methodToPayload{http.MethodPost: &DraftNotePublishRequest{}}),
|
|
withMethodCheck(http.MethodPost),
|
|
)
|
|
data := getSuccessData(t, svc, request)
|
|
assert(t, data.Message, "Draft note(s) published")
|
|
})
|
|
t.Run("Handles error from Gitlab", func(t *testing.T) {
|
|
request := makeRequest(t, http.MethodPost, "/mr/draft_notes/publish", testDraftNotePublishRequest)
|
|
svc := middleware(
|
|
draftNotePublisherService{testProjectData, fakeDraftNotePublisher{testBase: testBase{errFromGitlab: true}}},
|
|
withMr(testProjectData, fakeMergeRequestLister{}),
|
|
withPayloadValidation(methodToPayload{http.MethodPost: &DraftNotePublishRequest{}}),
|
|
withMethodCheck(http.MethodPost),
|
|
)
|
|
data, _ := getFailData(t, svc, request)
|
|
checkErrorFromGitlab(t, data, "Could not publish draft note(s)")
|
|
})
|
|
}
|