• removes the <esc> keybinding for popups which was causing folks to lose their changes
• deprecates the backup register.
• updates go-gitlab to latest in order to get "drafts" functionality
• fixes issues with labels not deleting correctly
• creates a new data() function to get data from the plugin directly, see :h gitlab.nvim.data
• fixes issues with line values not being computed directly, blocking jumps to/from discussion tree
This is a #MINOR release.
This MR is a #MAJOR breaking change to the plugin. While the plugin will continue to work for users with their existing settings, they will be informed of outdated configuration (diagnostics and signs have been simplified) the next time they open the reviewer.
Fix: Trim trailing slash from custom URLs
Update: .github/CONTRIBUTING.md, .github/ISSUE_TEMPLATE/bug_report.md
Feat: Improve discussion tree toggling (#192)
Fix: Toggle modified notes (#188)
Fix: Toggle discussion nodes correctly
Feat: Show Help keymap in discussion tree winbar
Fix: Enable toggling nodes from the note body
Fix: Enable toggling resolved status from child nodes
Fix: Only try to show emoji popup on note nodes
Feat: Add keymap for toggling tree type
Fix: Disable tree type toggling in Notes
Fix Multi Line Issues (Large Refactor) (#197)
Fix: Multi-line discussions. The calculation of a range for a multiline comment has been consolidated and moved into the location.lua file. This does not attempt to fix diagnostics.
Refactor: It refactors the discussions code to split hunk parsing and management into a separate module
Fix: Don't allow comments on modified buffers #194 by preventing comments on the reviewer when using --imply-local and when the working tree is dirty entirely.
Refactor: It introduces a new List class for data aggregation, filtering, etc.
Fix: It removes redundant API calls and refreshes from the discussion pane
Fix: Location provider (#198)
Fix: add nil check for Diffview performance issue (#199)
Fix: Switch Tabs During Comment Creation (#200)
Fix: Check if file is modified (#201)
Fix: Off-By-One Issue in Old SHA (#202)
Fix: Rebuild Diagnostics + Signs (#203)
Fix: Off-By-One Issue in New SHA (#205)
Fix: Reviewer Jumps to wrong location (#206)
BREAKING CHANGE: Changes configuration of diagnostics and signs in the setup call.
This MR adds the ability to view, add, and delete emojis from notes and comments.
This action can be performed by default with the `Ea` (emoji add) keybinding, and the `Ed` (emoji delete) keybinding. Only emojis added by the current user are eligible for deletion. The MR also implements a popup functionality which shows the user who added emojis on hover.
Implements #179
This MR adds the ability to add or remove labels to a merge request. These labels are visible in the summary panel and are colored the same way as they would be in the Gitlab UI.
This is a MINOR release.
- Adds the ability to create MRs to the plugin
- Adds the ability to jump to specific discussions/notes in the browser
- Fixes stale icons
- Adds debug keybinding for discussion tree for developers
This adds the ability to merge an MR from within `gitlab.nvim` directly. If the reviewer is open, it'll be closed automatically. Users may configure whether they'd like to squash commits on the merge, as well as whether they'd like to delete the original source branch on a merge.
If squashing, users are prompted to provide an optional custom squash message for the squash commit.
This MR adjusts the comment/discussion resolution action to resolve the entire discussion thread, rather than an individual comment, which is the expected behavior during an MR review.
This MR adds support for in-line comments in the review pane. This allows you to view comments (as diagnostics) directly in the Neovim buffers that you are reviewing. You can then jump to them directly in the discussion tree if you want to reply, edit, and so forth.
This MR removes the requirement for a dotfile (the dotfile is now optional and will override the configuration provided via environment variables). The requirement for providing a project ID is also eliminated, by parsing the namespace and project name from the SSH or HTTPS remote, and then using that to query Gitlab for a matching project.
This MR adds the ability to leave multi-line comments and suggested changes to an MR. The features are only supported for `diffview` because we plan to deprecate `delta` as a reviewer soon.
This plugin previously only supported the Delta reviewer. Thanks to work
from @mrparalon it now supports Diffview also. This MR adjusts the
requirements to account for this, and the README.
It also addresses a small bug in the original implementation regarding
an async file opening action, and applies formatting to the diffview
file consistent with the rest of the project
This MR adds the `.pipeline()` command which opens up the pipeline popup. This popup shows information about the current pipeline and it's jobs, and gives users the ability to re-trigger failed jobs.
BREAKING CHANGE: This MR addresses an underlying issue with the original implementation in regards to detecting line numbers for comments.
As such, this is a major breaking change. The setup function signature has changed, please review the `README.md` for the new arguments. The delta pager has also been added as a dependency: https://github.com/dandavison/delta
There will be future work to implement a native solution for parsing changes and line numbers.
This MR simplifies the plugin quite a bit by only attempting to start the Go server after you specifically try to run a command. This streamlines working on feature branches and removes the need for a `base_branch` property entirely.
Adds APIs for the ability to add or remove reviewers and assignees to a merge request. The eligible reviewers and assignees are pulled from the current members of a project.
This MR improves the configurability of the plugin by using Nui's split
system rather than managing the splits ourselves. This lets the user
configure both the positioning of the discussion tree and it's width,
and reduces overall maintenance of split management for the plugin.
This ensures that the state for the plugin has been initialized prior to
calling any of the other jobs. This ensures that they won't error if
called quickly after Neovim starts up
This should hopefully make it easier to debug and for users to figure
out what's going on by exposing the state of the plugin.
It is a Lua table, and can be seen via `:lua print(require("gitlab").state)`
The easiest way to print out a Lua table is with some sort of utility
function like this:
```
function printTable(...)
local objects = {}
for i = 1, select("#", ...) do
local v = select(i, ...)
table.insert(objects, vim.inspect(v))
end
print(table.concat(objects, "\n"))
return ...
end
```
This MR makes several major tweaks to the codebase. Primarily it adjusts
the setup steps for the application so that rather than providing just
the project ID in the `.gitlab.nvim` file, users can also provide a
vareity of other settings, such as auth_token, base_branch, and so
forth. This is to make the project more extensible in the future.
This MR also fixes a variety of issues with error handling in the code,
primarily in the request/response model between the Lua jobs and the
Golang server.
BREAKING CHANGE: Modifies `.gitlab.nvim` and setup steps
added a new file
First major commit
Successful POST of new comment 🚀
Updated README
Updated README 📕
Added more infrastructure
Creating async job
More setup
Getting arguments from Neovim -> Lua -> Golang
Moved commands
Added getProjectInfo command
Adding make comment command
Setting up arguments for MakeComment command
Removed extraneous comments
Setup basic function for adding comments
Lint fixes
Handling bad requests correctly
Better formatting
Printing success message
Adding utility table print
Set comment from popup UI
Added mappings for closing and sending text
Moved popup into separate file
Added comment
Cleaned up code and added approve command
Initialize project information
Removed extraneous import
Don't initialize project in non-gitlab directories
Setup approve command
Set up revoke and approve commands correctly
Cleaned up redundant code
Moved get current branch command
Reorganization of the code
First attempt to add step installing Go binary
Adjusted path to binary
Added install bin check
Do Lua method
Fixed install step
Tweaked binPath + bin
Added basic readme information 📗
Removed .luarc.json file
Adding diffview command
Added string_starts function
Made base branch configurable
Added note to readme
Fixed readme
Added diffview dep to readme
Update README.md
Update README.md
Update README.md
Update README.md
Renamed files
Set up developer workflow
Updated README
Removed dev note
Refactor and moving around files
Fixed ft/after mappings
Setup read command
Added read summary command
Got rid of filetype bindings and set up commands
Set correct filetype for comment buffer
Added read() command to README
Updated review -> summary
Fixed issue with diffview buffers
Added command for getting and showing all comments (out of order)
Better error message
Adding more code to handle showing comments
Added ability to jump from comment to specific changed buffer line
Initial refactor
Added simple comment action
Fixed error message
More cleanup
Fixed bug with M.PROJECT_ID
Leaving comment refactor
Fixed comment
Cleaned up old code
Added missing exit command
Check gitlab repo status before initialization
Better help strings
Added ListDiscussions command
Added Go code
Darkened metadata, filtered out non-real discussions
Removed dummy log
Sort the discussions by most recent activity
Grab hash of current discussion
Wired up reply action in Lua code
Moved to NUI Table
Adding basic jump-to-file ability
More tweaks
Allow jump anywhere in the tree
Ability to reply directly in the buffer window
Jump to location in file
Don't jump if no refresh is set
Cleaned up mappings + other code
Get rid of gitlab CLI dependency
Fixed discussions bug
Don't initialize client on main/master branches
Moved comment into separate module
Moved lua modules into separate files
Modularized library and state
Slightly better error/exception handling
Added license file
Updated readme
Moved into todo.md file
Added todo file
Standardized naming conventions (snake_case in Lua, camelCase in Go)
Moved common popup state into utils folder
Cleaned up keymapping functions
Note on install
Changing bin path
Updated README
Chnaged from success to info
Redirect output to /dev/null on build
Checking install code
Removed print statement
Slight reorganization
Setting up delete comment
Set up confirmation modal
Passing in node ID to delete_comment
Functioning comment deletion
Added delete_comment command
Updated README
Furhter modularized discussion code
Cleaned up and refactored reply code
Update README.md
Added ability to edit comments
Updated todos
Fixed main/master base branch issue
Set up keybinding rules
Updated todo.md
Removed diffview dependency
Slight cleanup 🧹
Trying something out...
Trying something for the binary...
Trying again
Fixed install for non-lazy users
Update README.md
Update README.md
Update README.md
Update README.md
Update README.md
