This MR adds the ability to leave multi-line comments and suggested changes to an MR. The features are only supported for `diffview` because we plan to deprecate `delta` as a reviewer soon.
BREAKING CHANGE: This MR addresses an underlying issue with the original implementation in regards to detecting line numbers for comments.
As such, this is a major breaking change. The setup function signature has changed, please review the `README.md` for the new arguments. The delta pager has also been added as a dependency: https://github.com/dandavison/delta
There will be future work to implement a native solution for parsing changes and line numbers.
We weren't writing a 200 status code post-delete because Gitlab returns
a 204 (empty but successful) by default. I updated this logic to change
that and also to refresh the tree.
The collapsed state of the tree will be wiped out if you delete a
bottom-level discussion but that's okay for now, not a high priority
right now.
* Changed to relative time
* Added days
* Updated display of discussion tree
* Updated a lot of functionality + behaviors for discussions + comments
* Modified state on deletion/creation
* Fixed relative times
This MR makes several major tweaks to the codebase. Primarily it adjusts
the setup steps for the application so that rather than providing just
the project ID in the `.gitlab.nvim` file, users can also provide a
vareity of other settings, such as auth_token, base_branch, and so
forth. This is to make the project more extensible in the future.
This MR also fixes a variety of issues with error handling in the code,
primarily in the request/response model between the Lua jobs and the
Golang server.
BREAKING CHANGE: Modifies `.gitlab.nvim` and setup steps
added a new file
First major commit
Successful POST of new comment 🚀
Updated README
Updated README 📕
Added more infrastructure
Creating async job
More setup
Getting arguments from Neovim -> Lua -> Golang
Moved commands
Added getProjectInfo command
Adding make comment command
Setting up arguments for MakeComment command
Removed extraneous comments
Setup basic function for adding comments
Lint fixes
Handling bad requests correctly
Better formatting
Printing success message
Adding utility table print
Set comment from popup UI
Added mappings for closing and sending text
Moved popup into separate file
Added comment
Cleaned up code and added approve command
Initialize project information
Removed extraneous import
Don't initialize project in non-gitlab directories
Setup approve command
Set up revoke and approve commands correctly
Cleaned up redundant code
Moved get current branch command
Reorganization of the code
First attempt to add step installing Go binary
Adjusted path to binary
Added install bin check
Do Lua method
Fixed install step
Tweaked binPath + bin
Added basic readme information 📗
Removed .luarc.json file
Adding diffview command
Added string_starts function
Made base branch configurable
Added note to readme
Fixed readme
Added diffview dep to readme
Update README.md
Update README.md
Update README.md
Update README.md
Renamed files
Set up developer workflow
Updated README
Removed dev note
Refactor and moving around files
Fixed ft/after mappings
Setup read command
Added read summary command
Got rid of filetype bindings and set up commands
Set correct filetype for comment buffer
Added read() command to README
Updated review -> summary
Fixed issue with diffview buffers
Added command for getting and showing all comments (out of order)
Better error message
Adding more code to handle showing comments
Added ability to jump from comment to specific changed buffer line
Initial refactor
Added simple comment action
Fixed error message
More cleanup
Fixed bug with M.PROJECT_ID
Leaving comment refactor
Fixed comment
Cleaned up old code
Added missing exit command
Check gitlab repo status before initialization
Better help strings
Added ListDiscussions command
Added Go code
Darkened metadata, filtered out non-real discussions
Removed dummy log
Sort the discussions by most recent activity
Grab hash of current discussion
Wired up reply action in Lua code
Moved to NUI Table
Adding basic jump-to-file ability
More tweaks
Allow jump anywhere in the tree
Ability to reply directly in the buffer window
Jump to location in file
Don't jump if no refresh is set
Cleaned up mappings + other code
Get rid of gitlab CLI dependency
Fixed discussions bug
Don't initialize client on main/master branches
Moved comment into separate module
Moved lua modules into separate files
Modularized library and state
Slightly better error/exception handling
Added license file
Updated readme
Moved into todo.md file
Added todo file
Standardized naming conventions (snake_case in Lua, camelCase in Go)
Moved common popup state into utils folder
Cleaned up keymapping functions
Note on install
Changing bin path
Updated README
Chnaged from success to info
Redirect output to /dev/null on build
Checking install code
Removed print statement
Slight reorganization
Setting up delete comment
Set up confirmation modal
Passing in node ID to delete_comment
Functioning comment deletion
Added delete_comment command
Updated README
Furhter modularized discussion code
Cleaned up and refactored reply code
Update README.md
Added ability to edit comments
Updated todos
Fixed main/master base branch issue
Set up keybinding rules
Updated todo.md
Removed diffview dependency
Slight cleanup 🧹
Trying something out...
Trying something for the binary...
Trying again
Fixed install for non-lazy users
Update README.md
Update README.md
Update README.md
Update README.md
Update README.md
