* Fix: Jumping to renamed files (#484)
* fix: prevent "cursor position outside buffer" error
* fix: swap file_name and old_file_name in reviewer data
`old_file_name` is not set to the empty string for un-renamed files anymore, because then we can
remove the empty-line check in `comment_helpers.go` which was used to replace the empty string with
the current file name anyway.
* fix: add old_file_name to discussion root node data
* fix: also consider old_file_name when jumping to the reviewer
This fixes jumping to renamed files, however, may not work for comments that
were created on renamed files with the previous version of `gitlab.nvim` as
that version assigned the `file_name` and `old_file_name` incorrectly.
* refactor: don't shadow variable
* fix: check file_name or old_file_name based on which SHA comment belongs to
* Fix: Store reviewer data before creating comment popup (#476)
* Fix: Make publishing drafts more robust (#483)
* Fix: Swap file_name and old_file_name in reviewer data (#485)
* Feat: Enable toggling date format between relative and absolute (#491)
* Fix: Add opts to help popup (#492)
* Fix: Force start_line for jumping to diagnostic to be inside buffer (#494)
* fix: redefine colors after reloading colorscheme (#500)
* Fix: Use path instead of oldpath as fallback for unrenamed files (#496)
* Fix: Use file_name when old_file_name is not set (#495)
* fix(ci): fix lua tests (#501)
* Proxy Support (#499)
* feat(ci): Cancel obsolete after a new commit is pushed in an open PR (#503)
* fix: start and clean up winbar timer properly (#513)
This is a PATCH.
* fix: put attach_file markdown on new line (#512)
This is a PATCH PR.
* docs: fix incorrect value for 'relative' option to Split (#511)
This is a PATCH.
* docs: add default keybinding maps available in the help (#506)
This is a PATCH change.
* feat: enable setting discussion tree options (#509)
* docs: add description of `refresh_data` function
* fix: only set gitlab filetype in one place
* feat: set some useful window options for the discussion tree split
This is a PATCH PR.
---------
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
Co-authored-by: Jonathan Duck <Duckbrain30@gmail.com>
Co-authored-by: Kitsios Konstantinos <kitsios.konst@gmail.com>
Co-authored-by: Mohammad Akbari <makbari@users.noreply.github.com>
* Fix: Jumping to renamed files (#484)
* fix: prevent "cursor position outside buffer" error
* fix: swap file_name and old_file_name in reviewer data
`old_file_name` is not set to the empty string for un-renamed files anymore, because then we can
remove the empty-line check in `comment_helpers.go` which was used to replace the empty string with
the current file name anyway.
* fix: add old_file_name to discussion root node data
* fix: also consider old_file_name when jumping to the reviewer
This fixes jumping to renamed files, however, may not work for comments that
were created on renamed files with the previous version of `gitlab.nvim` as
that version assigned the `file_name` and `old_file_name` incorrectly.
* refactor: don't shadow variable
* fix: check file_name or old_file_name based on which SHA comment belongs to
* Fix: Store reviewer data before creating comment popup (#476)
* Fix: Make publishing drafts more robust (#483)
* Fix: Swap file_name and old_file_name in reviewer data (#485)
* Feat: Enable toggling date format between relative and absolute (#491)
* Fix: Add opts to help popup (#492)
* Fix: Force start_line for jumping to diagnostic to be inside buffer (#494)
* fix: redefine colors after reloading colorscheme (#500)
* Fix: Use path instead of oldpath as fallback for unrenamed files (#496)
* Fix: Use file_name when old_file_name is not set (#495)
* fix(ci): fix lua tests (#501)
* Proxy Support (#499)
This is a #MINOR release.
---------
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
Co-authored-by: Jonathan Duck <Duckbrain30@gmail.com>
Fix: Jumping to renamed files (#484)
Fix: Store reviewer data before creating comment popup (#476)
Fix: Make publishing drafts more robust (#483)
Fix: Swap file_name and old_file_name in reviewer data (#485)
---------
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
* fix: Restore buffer local settings outside reviewer (#446)
* fix: do not show healthcheck alert for warnings (#468)
* feat: Add MR URL to the summary details (#467)
* fix: make cycling reviewed files faster (#474)
* feat(pipeline): display trigger jobs for a pipeline in the pipelines popup (#465)
* fix: Jumping to renamed files (#484)
---------
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
Co-authored-by: Ashish Alex <ashish.alex10@gmail.com>
Miscellaneous bug fixes and improvements.
docs: various improvements (#445)
fix: don't jump to file from reviewer if it doesn't exist (#452)
fix: force linewise motion in suggestion keybinding (#454)
fix: prevent error after plenary job update (#456)
fix: fix JSON on Windows (#458)
fix: remove retry logic (#449)
fix: check whether comment can be created (#434)
fix: Show non-resolvable notes in winbar (#417)
fix: add more emojis and make emoji picker configurable (#414)
fix: comment creation should not be possible for renamed and moved files (#416)
fix: color highlight groups are invalid (#421)
fix: plugin failing to build on Windows (#419)
---------
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
fix: parse dates without timezone offset (#404)
fix: enable replying if tree is in a different tab (#407)
fix: wrong get url (#413)
fix: Restore cursor when updating from outside of tree (#406)
---------
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
Co-authored-by: Oscar <oscar.creator13@gmail.com>
fix: Error messages and run all tests (#381)
feat: Automatically open fold under cursor (#380)
fix: Discussion ID is not required (#383)
chore: Add more emojis (#384)
fix: Publish all drafts (#391)
fix: Make discussion tree buffers no-modifiable (#394)
fix: Incorrect warning about commits (#395)
fix: Show draft replies in the correct tree (#396)
fix: Cannot choose merge requests (#398)
---------
Co-authored-by: George Kontridze <george.kontridze@gmail.com>
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
* fix: error messages and run all tests (#381)
* feat: Automatically open fold under cursor (#380)
* fix: discussion ID is not required (#383)
This is a #PATCH release.
---------
Co-authored-by: George Kontridze <george.kontridze@gmail.com>
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
fix: format of date when MR was closed or merged (#367)
refactor: Add Payload Validators + Middleware In Go Code (#366)
fix: Add better checks for leaving comments (#369)
fix: regex support for http credentials embedded in remote url (#372)
fix: Comment on single line selects two lines (#371)
This is a #PATCH release.
refactor: Refactors the Go codebase into a more modular and idiomatic approach
fix: require selection of specific MR when there are multiple targets for a given source branch
feat: Allows for the passing of Gitlab's filter options when choosing an MR, improves MR selection
feat: API to choose an MR from a list based on the provided username's involvement as an assignee/reviewer/author
This is a #MINOR release
feat: Enable always jumping to discussion tree (#352)
feat: Enables motions for easier range selection when creating comments/suggestions (e.g. s3j, c3j) (#353)
fix: Makes help popup not editable and close it on BufLeave (#355)
This is a #MINOR release
feat: add filtering when choosing merge requests (#346)
feat: Add healthcheck (#345)
refactor: Move to gomock (#349)
feat: Makes the remote of the plugin configurable (#348)
This is a #MINOR release.
This is a breaking change to the way the plugin is configured. If users are using the old configuration the plugin will warn them which fields have been removed in their configuration. Old keybindings can be found here: https://github.com/harrisoncramer/gitlab.nvim/pull/340#issuecomment-2282756924 (#331)
feat: Customize discussion tree chevrons (#339)
Fix diagnostic position when sha changes (#299)
Fix: Remove API calls on Discussion Close (#328)
Chore: Remove root node type (#329)
This is a PATCH release.
Fix: Only set autocommands for select popups (#315)
Docs: Small improvements to README and docs
Feat: Add branch info to choose_merge_request menu (#318)
Chore: Add heart emoji (#323)
Feat: Add highlight for mentions (#324)
Fix: Do Not Error w/Out Buffer Content (#325)
This is a MINOR release.
* Fix docs: choose_merge_request's open_reviewer default value is true (#316)
* Fix: Only set autocommands for select popups (#315)
* Docs: Small improvements to README and docs
* Feat: Add branch info to choose_merge_request menu (#318)
This is a PATCH release.
fix: List remote branches for merge targets (#293)
fix: consider remote branches (#297)
fix: Save popup contents to temp_registers (#294)
This is a #PATCH release.
* fix: always refresh discussion tree data after choosing a new branch
* fix: rebuild discussion tree without collapsing nodes after all edit/delete/create actions
* feat: add command to refresh discussion tree
* feat: Add support for draft note replies, e.g. replies to existing notes and comments in draft form
* fix: allow backticks in comment suggestions
This is a #MINOR release
* feat: Support for custom authentication provider functions (#270)
* feat: Support for adding "draft" notes to the review, and publishing them, either individually or all at once. Addresses feature request #223.
* feat: Lets users select + checkout a merge request directly within Neovim, without exiting to the terminal
* fix: Checks that the remote feature branch exists and is up-to-date before creating a MR, starting a review, or opening the MR summary (#278)
* docs: We require some state from Diffview, this shows how to load that state prior to installing w/ Packer. Fixes#94.
This is a #MINOR release.
---------
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
Co-authored-by: sunfuze <sunfuze.1989@gmail.com>
Co-authored-by: Patrick Pichler <mail@patrickpichler.dev>
* fix: Jumping to wrong buffer (#261)
* fix: Go to last line and show warning when diagnostic is past the end of buffer (#262)
* fix: Get recent pipeline through other means (#266)
* feat: Add keymaps and linewise actions to layouts (#265)
This is a #MINOR release, because we are introducing new keybindings for the comment/note popups.
---------
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
Co-authored-by: sunfuze <sunfuze.1989@gmail.com>
- fix: an autocommand issue when creating an MR
- feat: adds a keybinding for copying the URL of the current discussion to the system clipboard
This is a #MINOR release
- allows SSH Gitlab connection to have custom port
- introduces temporary registers
- fixes issue w/ quitting the popup on MR creation
This is a #MINOR release
• removes the <esc> keybinding for popups which was causing folks to lose their changes
• deprecates the backup register.
• updates go-gitlab to latest in order to get "drafts" functionality
• fixes issues with labels not deleting correctly
• creates a new data() function to get data from the plugin directly, see :h gitlab.nvim.data
• fixes issues with line values not being computed directly, blocking jumps to/from discussion tree
This is a #MINOR release.
This MR makes it possible to ignore bad x509 certificates when connecting to Gitlab, by creating a custom HTTP connection. The option is exposed via the setup function. This is a PATCH release.
This MR changes the hunk parsing strategy for ranged comments in the new SHA. Now, we're only parsing and comparing the new lines. Fixes an issue where you could leave a ranged comment in the new buffer on an unchanged line and the plugin would not detect the line number correctly.
This MR is a #MAJOR breaking change to the plugin. While the plugin will continue to work for users with their existing settings, they will be informed of outdated configuration (diagnostics and signs have been simplified) the next time they open the reviewer.
Fix: Trim trailing slash from custom URLs
Update: .github/CONTRIBUTING.md, .github/ISSUE_TEMPLATE/bug_report.md
Feat: Improve discussion tree toggling (#192)
Fix: Toggle modified notes (#188)
Fix: Toggle discussion nodes correctly
Feat: Show Help keymap in discussion tree winbar
Fix: Enable toggling nodes from the note body
Fix: Enable toggling resolved status from child nodes
Fix: Only try to show emoji popup on note nodes
Feat: Add keymap for toggling tree type
Fix: Disable tree type toggling in Notes
Fix Multi Line Issues (Large Refactor) (#197)
Fix: Multi-line discussions. The calculation of a range for a multiline comment has been consolidated and moved into the location.lua file. This does not attempt to fix diagnostics.
Refactor: It refactors the discussions code to split hunk parsing and management into a separate module
Fix: Don't allow comments on modified buffers #194 by preventing comments on the reviewer when using --imply-local and when the working tree is dirty entirely.
Refactor: It introduces a new List class for data aggregation, filtering, etc.
Fix: It removes redundant API calls and refreshes from the discussion pane
Fix: Location provider (#198)
Fix: add nil check for Diffview performance issue (#199)
Fix: Switch Tabs During Comment Creation (#200)
Fix: Check if file is modified (#201)
Fix: Off-By-One Issue in Old SHA (#202)
Fix: Rebuild Diagnostics + Signs (#203)
Fix: Off-By-One Issue in New SHA (#205)
Fix: Reviewer Jumps to wrong location (#206)
BREAKING CHANGE: Changes configuration of diagnostics and signs in the setup call.
This MR re-implements and fixes logic that better handles single-line comments. It does this by parsing the hunk headers and examining the actual changes they contain in order to form the Gitlab payload correctly. Addresses #128
This MR adds the ability to view, add, and delete emojis from notes and comments.
This action can be performed by default with the `Ea` (emoji add) keybinding, and the `Ed` (emoji delete) keybinding. Only emojis added by the current user are eligible for deletion. The MR also implements a popup functionality which shows the user who added emojis on hover.
Implements #179
This MR adds the ability to expand and collapse nodes in the discussion tree in bulk. You can now toggle expansion of all nodes, toggle expansion of only resolved discussions, and toggle expansion of only unresolved discussions.
The MR also adjusts keybindings in the discussion tree to support forward and backward searching, as well as the keybinding for the help popup.
Thank you for the contribution @jakubbortlik!
This is a #MINOR bump since it's changing keybindings, although core workflows are unchanged.
This MR fixes an issue where someone could leave a note on an MR without opening the discussion tree first. We want to avoid throwing an error by attempting to update the discussion tree if it doesn't already exist.
* Docs: Fix typos and remove trailing spaces
* Fix: Split strings by new lines correctly
* Docs: Recommend breakindent option to improve tree nodes indentation
* Fix: Replace whole buffer when creating a new suggestion
Previously, a trailing empty line was left in the buffer.
---------
Co-authored-by: Jakub Bortlík <jakub.bortlik@phonexia.com>
Users can now provide a backup register when creating comments, notes, and so forth which will automatically be populated with the contents of the buffer prior to submission to Gitlab. This ensures that even if the API call fails the contents of the buffer is saved, which prevents the user from losing their changes. This is a MINOR update.
