Commit Graph

240 Commits

Author SHA1 Message Date
Harrison Cramer
72a263d346 Bugfix: Fixes server.start() command 2023-08-28 08:25:30 -04:00
Harrison Cramer
c29fa4f43f Bugfix: Fixed default state 2023-08-28 08:21:31 -04:00
Harrison (Harry) Cramer
3108a3709f Update README.md 2023-08-27 17:28:21 -04:00
Harrison (Harry) Cramer
dfded0f3bd Update README.md 2023-08-27 17:27:47 -04:00
Harrison (Harry) Cramer
19468a3d2d BREAKING CHANGE: Delta Pager + Large Refactor (#43)
BREAKING CHANGE: This MR addresses an underlying issue with the original implementation in regards to detecting line numbers for comments. 

As such, this is a major breaking change. The setup function signature has changed, please review the `README.md` for the new arguments. The delta pager has also been added as a dependency: https://github.com/dandavison/delta

There will be future work to implement a native solution for parsing changes and line numbers.
2023-08-27 17:26:54 -04:00
Harrison (Harry) Cramer
ed67a03f8f Update README.md 2023-08-20 21:53:47 -04:00
Harrison (Harry) Cramer
2c0fc2b57e Update README.md 2023-08-20 21:53:34 -04:00
Harrison (Harry) Cramer
5cb5170f3a Update README.md 2023-08-20 21:53:23 -04:00
Harrison (Harry) Cramer
f7cdd38d5f Update README.md 2023-08-20 21:52:39 -04:00
Harrison (Harry) Cramer
2920c67fe2 Update README.md 2023-08-20 21:50:52 -04:00
Harrison (Harry) Cramer
27c54b4739 Cleanup of comment creation (#42)
Refactor of comment creation code
2023-08-19 00:27:11 -04:00
Harrison Cramer
ce5dd1aaa2 Fixes #28
We do not want to attempt to refresh the discussion tree if the buffer has been
deleted.
2023-08-18 21:38:27 -04:00
Harrison Cramer
16ed361333 Added lots of comments and documentation 📘 2023-08-18 19:23:44 -04:00
Harrison Cramer
2846dd3239 Slight cleanup + simplification of init state 2023-08-18 19:23:44 -04:00
Harrison (Harry) Cramer
57b3f12a2f Update README.md 2023-08-18 16:17:46 -04:00
Harrison (Harry) Cramer
b664406e50 Update README.md 2023-08-18 07:55:57 -04:00
Harrison (Harry) Cramer
2d6ba691f4 Update bug_report.md 2023-08-17 17:19:00 -04:00
Harrison (Harry) Cramer
2395353e5f Update README.md 2023-08-17 17:16:27 -04:00
Harrison Cramer
8c9d46ceb5 Broke require("gitlab").start_server() command into separate function
This will make debugging easier!
2023-08-17 17:13:35 -04:00
Harrison Cramer
14bb2800e5 Remove branch logic 2023-08-17 16:35:55 -04:00
Harrison Cramer
0ccff54933 Remove unused branch_exists function 2023-08-17 16:24:29 -04:00
Harrison (Harry) Cramer
f5bf720b61 Bugfix: Don't Start Server Right Away (#40)
This MR simplifies the plugin quite a bit by only attempting to start the Go server after you specifically try to run a command. This streamlines working on feature branches and removes the need for a `base_branch` property entirely.
2023-08-17 16:22:53 -04:00
Harrison (Harry) Cramer
f4aafe46a9 Update README.md 2023-08-17 12:42:52 -04:00
Harrison (Harry) Cramer
d25c62ae9f Adding Support for Resolving/Unresolving Discussions (#39)
This MR adds the ability to mark discussions as resolved or unresolved. This is important to the review process.
2023-08-17 12:42:36 -04:00
Harrison (Harry) Cramer
1676992266 Update README.md 2023-08-16 21:43:51 -04:00
Harrison (Harry) Cramer
844e093294 Add/Remove Reviewers and Assignees (#38)
Adds APIs for the ability to add or remove reviewers and assignees to a merge request. The eligible reviewers and assignees are pulled from the current members of a project.
2023-08-16 21:42:53 -04:00
Harrison (Harry) Cramer
6274746d4b Update README.md
The token should be GITLAB_TOKEN when set in the shell.
2023-08-16 19:11:42 -04:00
Harrison (Harry) Cramer
6bb7575c6d Attach UUIDs to Discussion Text (#37)
Three backticks will break the discussion tree, this MR specifically adds custom UUIDs to each text node to avoid this issue.
2023-08-15 23:33:52 -04:00
Harrison (Harry) Cramer
4f1a0f9c57 Update README.md 2023-08-15 12:03:16 -04:00
Harrison Cramer
146d7d3936 Updated issue templates 2023-08-15 08:26:26 -04:00
Harrison (Harry) Cramer
d9a744300e Fixes #28 (#33)
We weren't writing a 200 status code post-delete because Gitlab returns
a 204 (empty but successful) by default. I updated this logic to change
that and also to refresh the tree.

The collapsed state of the tree will be wiped out if you delete a
bottom-level discussion but that's okay for now, not a high priority
right now.
2023-08-14 23:16:18 -04:00
Harrison (Harry) Cramer
648e7a298b Fix #19 (#32) 2023-08-14 22:44:35 -04:00
Harrison (Harry) Cramer
76055d2652 Fixes #29 (#31)
We want to pick the note ID more carefully for deletion.

If it's the root node (aka the first comment in a discussion thread) then
we want to choose the root_note_id since that is the ID of the first
comment in the discussion. Otherwise, we want to choose the note_node
ID.
2023-08-14 21:49:07 -04:00
Harrison (Harry) Cramer
8724847d5a Addresses issue with #20 (#30) 2023-08-14 21:34:54 -04:00
Harrison (Harry) Cramer
2028be2154 Feat: Edit PR Description (#22)
This MR makes it possible to edit the description. Non-breaking, will happen within the normal description popup.
2023-08-14 20:37:36 -04:00
Harrison (Harry) Cramer
35d5b619ce Fixes #26 (#27) 2023-08-14 19:25:54 -04:00
Harrison (Harry) Cramer
1963e49d63 Update README.md 2023-08-14 18:23:37 -04:00
Harrison Cramer
0a4ce10aa1 Removed extra log 2023-08-14 17:59:40 -04:00
Harrison (Harry) Cramer
fd99159c3d Update README.md 2023-08-14 17:48:48 -04:00
Harrison (Harry) Cramer
432a9b7ef2 Update README.md 2023-08-14 17:25:10 -04:00
Harrison (Harry) Cramer
b4077ba8c2 Feat: Discussion Changes + Code Cleanup (#24)
* Changed to relative time

* Added days

* Updated display of discussion tree

* Updated a lot of functionality + behaviors for discussions + comments

* Modified state on deletion/creation

* Fixed relative times
2023-08-14 17:19:39 -04:00
Harrison (Harry) Cramer
8349bccb29 Update README.md
Fixed optional log path property!
2023-08-14 17:00:48 -04:00
Harrison (Harry) Cramer
7dfd6d24e7 Update README.md 2023-08-14 07:43:17 -04:00
Harrison (Harry) Cramer
dce74035eb Update README.md
Updated the "Troubleshooting" Section
2023-08-14 07:42:53 -04:00
Harrison (Harry) Cramer
a5dde79ea8 Update README.md 2023-08-14 07:24:23 -04:00
Harrison Cramer
97195d4ab5 Feat: Configure discussion tree split width and position
This MR improves the configurability of the plugin by using Nui's split
system rather than managing the splits ourselves. This lets the user
configure both the positioning of the discussion tree and it's width,
and reduces overall maintenance of split management for the plugin.
2023-08-12 14:36:48 -04:00
Harrison Cramer
e958b35bd5 Minor comment changes in init.lua 2023-08-12 13:12:54 -04:00
Harrison Cramer
feff814b56 Bugfix: State Initialization
This ensures that the state for the plugin has been initialized prior to
calling any of the other jobs. This ensures that they won't error if
called quickly after Neovim starts up
2023-08-12 13:07:04 -04:00
Harrison Cramer
7e4ca89198 Expose state for debugging purposes
This should hopefully make it easier to debug and for users to figure
out what's going on by exposing the state of the plugin.

It is a Lua table, and can be seen via `:lua print(require("gitlab").state)`

The easiest way to print out a Lua table is with some sort of utility
function like this:

```
function printTable(...)
  local objects = {}
  for i = 1, select("#", ...) do
    local v = select(i, ...)
    table.insert(objects, vim.inspect(v))
  end

  print(table.concat(objects, "\n"))
  return ...
end
```
2023-08-11 21:05:31 -04:00
Harrison Cramer
3d3bb764ba Bugfix: The job might not return JSON data, so we don't need to throw
here
2023-08-09 17:30:36 -04:00