* Fix: Jumping to renamed files (#484)
* fix: prevent "cursor position outside buffer" error
* fix: swap file_name and old_file_name in reviewer data
`old_file_name` is not set to the empty string for un-renamed files anymore, because then we can
remove the empty-line check in `comment_helpers.go` which was used to replace the empty string with
the current file name anyway.
* fix: add old_file_name to discussion root node data
* fix: also consider old_file_name when jumping to the reviewer
This fixes jumping to renamed files, however, may not work for comments that
were created on renamed files with the previous version of `gitlab.nvim` as
that version assigned the `file_name` and `old_file_name` incorrectly.
* refactor: don't shadow variable
* fix: check file_name or old_file_name based on which SHA comment belongs to
* Fix: Store reviewer data before creating comment popup (#476)
* Fix: Make publishing drafts more robust (#483)
* Fix: Swap file_name and old_file_name in reviewer data (#485)
* Feat: Enable toggling date format between relative and absolute (#491)
* Fix: Add opts to help popup (#492)
* Fix: Force start_line for jumping to diagnostic to be inside buffer (#494)
* fix: redefine colors after reloading colorscheme (#500)
* Fix: Use path instead of oldpath as fallback for unrenamed files (#496)
* Fix: Use file_name when old_file_name is not set (#495)
* fix(ci): fix lua tests (#501)
* Proxy Support (#499)
* feat(ci): Cancel obsolete after a new commit is pushed in an open PR (#503)
* fix: start and clean up winbar timer properly (#513)
This is a PATCH.
* fix: put attach_file markdown on new line (#512)
This is a PATCH PR.
* docs: fix incorrect value for 'relative' option to Split (#511)
This is a PATCH.
* docs: add default keybinding maps available in the help (#506)
This is a PATCH change.
* feat: enable setting discussion tree options (#509)
* docs: add description of `refresh_data` function
* fix: only set gitlab filetype in one place
* feat: set some useful window options for the discussion tree split
This is a PATCH PR.
---------
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
Co-authored-by: Jonathan Duck <Duckbrain30@gmail.com>
Co-authored-by: Kitsios Konstantinos <kitsios.konst@gmail.com>
Co-authored-by: Mohammad Akbari <makbari@users.noreply.github.com>
* Fix: Jumping to renamed files (#484)
* fix: prevent "cursor position outside buffer" error
* fix: swap file_name and old_file_name in reviewer data
`old_file_name` is not set to the empty string for un-renamed files anymore, because then we can
remove the empty-line check in `comment_helpers.go` which was used to replace the empty string with
the current file name anyway.
* fix: add old_file_name to discussion root node data
* fix: also consider old_file_name when jumping to the reviewer
This fixes jumping to renamed files, however, may not work for comments that
were created on renamed files with the previous version of `gitlab.nvim` as
that version assigned the `file_name` and `old_file_name` incorrectly.
* refactor: don't shadow variable
* fix: check file_name or old_file_name based on which SHA comment belongs to
* Fix: Store reviewer data before creating comment popup (#476)
* Fix: Make publishing drafts more robust (#483)
* Fix: Swap file_name and old_file_name in reviewer data (#485)
* Feat: Enable toggling date format between relative and absolute (#491)
* Fix: Add opts to help popup (#492)
* Fix: Force start_line for jumping to diagnostic to be inside buffer (#494)
* fix: redefine colors after reloading colorscheme (#500)
* Fix: Use path instead of oldpath as fallback for unrenamed files (#496)
* Fix: Use file_name when old_file_name is not set (#495)
* fix(ci): fix lua tests (#501)
* Proxy Support (#499)
This is a #MINOR release.
---------
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
Co-authored-by: Jonathan Duck <Duckbrain30@gmail.com>
* fix: Restore buffer local settings outside reviewer (#446)
* fix: do not show healthcheck alert for warnings (#468)
* feat: Add MR URL to the summary details (#467)
* fix: make cycling reviewed files faster (#474)
* feat(pipeline): display trigger jobs for a pipeline in the pipelines popup (#465)
* fix: Jumping to renamed files (#484)
---------
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
Co-authored-by: Ashish Alex <ashish.alex10@gmail.com>
refactor: Refactors the Go codebase into a more modular and idiomatic approach
fix: require selection of specific MR when there are multiple targets for a given source branch
feat: Allows for the passing of Gitlab's filter options when choosing an MR, improves MR selection
feat: API to choose an MR from a list based on the provided username's involvement as an assignee/reviewer/author
This is a #MINOR release
feat: add filtering when choosing merge requests (#346)
feat: Add healthcheck (#345)
refactor: Move to gomock (#349)
feat: Makes the remote of the plugin configurable (#348)
This is a #MINOR release.
This MR is a #MAJOR breaking change to the plugin. While the plugin will continue to work for users with their existing settings, they will be informed of outdated configuration (diagnostics and signs have been simplified) the next time they open the reviewer.
Fix: Trim trailing slash from custom URLs
Update: .github/CONTRIBUTING.md, .github/ISSUE_TEMPLATE/bug_report.md
Feat: Improve discussion tree toggling (#192)
Fix: Toggle modified notes (#188)
Fix: Toggle discussion nodes correctly
Feat: Show Help keymap in discussion tree winbar
Fix: Enable toggling nodes from the note body
Fix: Enable toggling resolved status from child nodes
Fix: Only try to show emoji popup on note nodes
Feat: Add keymap for toggling tree type
Fix: Disable tree type toggling in Notes
Fix Multi Line Issues (Large Refactor) (#197)
Fix: Multi-line discussions. The calculation of a range for a multiline comment has been consolidated and moved into the location.lua file. This does not attempt to fix diagnostics.
Refactor: It refactors the discussions code to split hunk parsing and management into a separate module
Fix: Don't allow comments on modified buffers #194 by preventing comments on the reviewer when using --imply-local and when the working tree is dirty entirely.
Refactor: It introduces a new List class for data aggregation, filtering, etc.
Fix: It removes redundant API calls and refreshes from the discussion pane
Fix: Location provider (#198)
Fix: add nil check for Diffview performance issue (#199)
Fix: Switch Tabs During Comment Creation (#200)
Fix: Check if file is modified (#201)
Fix: Off-By-One Issue in Old SHA (#202)
Fix: Rebuild Diagnostics + Signs (#203)
Fix: Off-By-One Issue in New SHA (#205)
Fix: Reviewer Jumps to wrong location (#206)
BREAKING CHANGE: Changes configuration of diagnostics and signs in the setup call.
This makes the popups in the plugin (those for editing and creating comments, replies, the pipeline, etc) configurable. Users can change the default width, height, transparency, and border properties, and set overrides per popup.
This MR adds the ability to sort discussions by file name, rather than just by date.
This is an optional configuration that can be passed in on startup. The MR also introduces a test suite for the Lua code that runs through Neovim, so that the plugin can be fully tested with required dependencies and APIs.
Major props to @johnybx for the hard work on this change!
This MR represents a major refactor of the Go codebase, as well as introducing tests for the handlers. The MR also introduces an endpoint to shutdown or restart the Go server, which may be useful for clients who want to refresh the state of the plugin after checking out branches. Finally, this MR adds a contributing document for users who want to make feature changes.
This MR adds a Lua test suite to the project, run via busted, and introduces tests for a number of the utility functions. Subsequent work will have to be done to test functions that use the `vim.api` scope and external packages to the plugin.
