Release (#256)
* fix: Jumping to wrong buffer (#261) * fix: Go to last line and show warning when diagnostic is past the end of buffer (#262) * fix: Get recent pipeline through other means (#266) * feat: Add keymaps and linewise actions to layouts (#265) This is a #MINOR release, because we are introducing new keybindings for the comment/note popups. --------- Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me> Co-authored-by: sunfuze <sunfuze.1989@gmail.com>
This commit is contained in:
committed by
GitHub
parent
138b96baea
commit
f906af0c3a
@@ -32,17 +32,27 @@ func retryPipelineBuildNon200(pid interface{}, pipeline int, options ...gitlab.R
|
||||
return nil, makeResponse(http.StatusSeeOther), nil
|
||||
}
|
||||
|
||||
func getLatestPipeline200(pid interface{}, opts *gitlab.GetLatestPipelineOptions, options ...gitlab.RequestOptionFunc) (*gitlab.Pipeline, *gitlab.Response, error) {
|
||||
return &gitlab.Pipeline{ID: 1}, makeResponse(http.StatusOK), nil
|
||||
func listProjectPipelines(pid interface{}, opt *gitlab.ListProjectPipelinesOptions, options ...gitlab.RequestOptionFunc) ([]*gitlab.PipelineInfo, *gitlab.Response, error) {
|
||||
return []*gitlab.PipelineInfo{
|
||||
{ID: 12345},
|
||||
}, makeResponse(http.StatusOK), nil
|
||||
}
|
||||
|
||||
func withGitInfo(a *api) error {
|
||||
a.gitInfo.GetLatestCommitOnRemote = func(a *api) (string, error) {
|
||||
return "123abc", nil
|
||||
}
|
||||
a.gitInfo.BranchName = "some-feature"
|
||||
return nil
|
||||
}
|
||||
|
||||
func TestPipelineHandler(t *testing.T) {
|
||||
t.Run("Gets all pipeline jobs", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodGet, "/pipeline", nil)
|
||||
server, _ := createRouterAndApi(fakeClient{
|
||||
listPipelineJobs: listPipelineJobs,
|
||||
getLatestPipeline: getLatestPipeline200,
|
||||
})
|
||||
listPipelineJobs: listPipelineJobs,
|
||||
listProjectPipelines: listProjectPipelines,
|
||||
}, withGitInfo)
|
||||
data := serveRequest(t, server, request, GetPipelineAndJobsResponse{})
|
||||
assert(t, data.SuccessResponse.Message, "Pipeline retrieved")
|
||||
assert(t, data.SuccessResponse.Status, http.StatusOK)
|
||||
@@ -51,9 +61,9 @@ func TestPipelineHandler(t *testing.T) {
|
||||
t.Run("Disallows non-GET, non-POST methods", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodPatch, "/pipeline", nil)
|
||||
server, _ := createRouterAndApi(fakeClient{
|
||||
listPipelineJobs: listPipelineJobs,
|
||||
getLatestPipeline: getLatestPipeline200,
|
||||
})
|
||||
listPipelineJobs: listPipelineJobs,
|
||||
listProjectPipelines: listProjectPipelines,
|
||||
}, withGitInfo)
|
||||
data := serveRequest(t, server, request, ErrorResponse{})
|
||||
checkBadMethod(t, *data, http.MethodGet, http.MethodPost)
|
||||
})
|
||||
@@ -61,9 +71,9 @@ func TestPipelineHandler(t *testing.T) {
|
||||
t.Run("Handles errors from Gitlab client", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodGet, "/pipeline", nil)
|
||||
server, _ := createRouterAndApi(fakeClient{
|
||||
listPipelineJobs: listPipelineJobsErr,
|
||||
getLatestPipeline: getLatestPipeline200,
|
||||
})
|
||||
listPipelineJobs: listPipelineJobsErr,
|
||||
listProjectPipelines: listProjectPipelines,
|
||||
}, withGitInfo)
|
||||
data := serveRequest(t, server, request, ErrorResponse{})
|
||||
checkErrorFromGitlab(t, *data, "Could not get pipeline jobs")
|
||||
})
|
||||
@@ -71,9 +81,9 @@ func TestPipelineHandler(t *testing.T) {
|
||||
t.Run("Handles non-200s from Gitlab client", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodGet, "/pipeline", nil)
|
||||
server, _ := createRouterAndApi(fakeClient{
|
||||
listPipelineJobs: listPipelineJobsNon200,
|
||||
getLatestPipeline: getLatestPipeline200,
|
||||
})
|
||||
listPipelineJobs: listPipelineJobsNon200,
|
||||
listProjectPipelines: listProjectPipelines,
|
||||
}, withGitInfo)
|
||||
data := serveRequest(t, server, request, ErrorResponse{})
|
||||
checkNon200(t, *data, "Could not get pipeline jobs", "/pipeline")
|
||||
})
|
||||
@@ -81,9 +91,9 @@ func TestPipelineHandler(t *testing.T) {
|
||||
t.Run("Handles errors from Gitlab client", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodPost, "/pipeline/trigger/1", nil)
|
||||
server, _ := createRouterAndApi(fakeClient{
|
||||
retryPipelineBuild: retryPipelineBuildErr,
|
||||
getLatestPipeline: getLatestPipeline200,
|
||||
})
|
||||
retryPipelineBuild: retryPipelineBuildErr,
|
||||
listProjectPipelines: listProjectPipelines,
|
||||
}, withGitInfo)
|
||||
data := serveRequest(t, server, request, ErrorResponse{})
|
||||
checkErrorFromGitlab(t, *data, "Could not retrigger pipeline")
|
||||
})
|
||||
@@ -91,9 +101,9 @@ func TestPipelineHandler(t *testing.T) {
|
||||
t.Run("Retriggers pipeline", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodPost, "/pipeline/trigger/1", nil)
|
||||
server, _ := createRouterAndApi(fakeClient{
|
||||
retryPipelineBuild: retryPipelineBuild,
|
||||
getLatestPipeline: getLatestPipeline200,
|
||||
})
|
||||
retryPipelineBuild: retryPipelineBuild,
|
||||
listProjectPipelines: listProjectPipelines,
|
||||
}, withGitInfo)
|
||||
data := serveRequest(t, server, request, GetPipelineAndJobsResponse{})
|
||||
assert(t, data.SuccessResponse.Message, "Pipeline retriggered")
|
||||
assert(t, data.SuccessResponse.Status, http.StatusOK)
|
||||
@@ -102,9 +112,9 @@ func TestPipelineHandler(t *testing.T) {
|
||||
t.Run("Handles non-200s from Gitlab client on retrigger", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodPost, "/pipeline/trigger/1", nil)
|
||||
server, _ := createRouterAndApi(fakeClient{
|
||||
retryPipelineBuild: retryPipelineBuildNon200,
|
||||
getLatestPipeline: getLatestPipeline200,
|
||||
})
|
||||
retryPipelineBuild: retryPipelineBuildNon200,
|
||||
listProjectPipelines: listProjectPipelines,
|
||||
}, withGitInfo)
|
||||
data := serveRequest(t, server, request, ErrorResponse{})
|
||||
checkNon200(t, *data, "Could not retrigger pipeline", "/pipeline")
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user