From f10c4ebb8f1618e5d9a0efae34d76e20c472960f Mon Sep 17 00:00:00 2001
From: "Harrison (Harry) Cramer"
 <32515581+harrisoncramer@users.noreply.github.com>
Date: Sat, 20 Apr 2024 11:36:26 -0400
Subject: [PATCH] fixes line number for diagnostics in old sha (#276)

fix: place line number on correct line in old SHA

This is a #PATCH release
---
 lua/gitlab/indicators/diagnostics.lua | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lua/gitlab/indicators/diagnostics.lua b/lua/gitlab/indicators/diagnostics.lua
index 7548a9b..67b6d41 100644
--- a/lua/gitlab/indicators/diagnostics.lua
+++ b/lua/gitlab/indicators/diagnostics.lua
@@ -48,8 +48,9 @@ end
 ---@return Diagnostic
 local create_single_line_diagnostic = function(discussion)
   local first_note = discussion.notes[1]
+  local linnr = (common.is_new_sha(discussion) and first_note.position.new_line or first_note.position.old_line) or 1
   return create_diagnostic({
-    lnum = (first_note.position.new_line or first_note.position.old_line) - 1,
+    lnum = linnr - 1,
   }, discussion)
 end