Fix MR Selection, Go Code Refactor (#358)
refactor: Refactors the Go codebase into a more modular and idiomatic approach fix: require selection of specific MR when there are multiple targets for a given source branch feat: Allows for the passing of Gitlab's filter options when choosing an MR, improves MR selection feat: API to choose an MR from a list based on the provided username's involvement as an assignee/reviewer/author This is a #MINOR release
This commit is contained in:
committed by
GitHub
parent
6500ef1f2c
commit
ea2b2b2f5c
85
cmd/app/reviewer.go
Normal file
85
cmd/app/reviewer.go
Normal file
@@ -0,0 +1,85 @@
|
||||
package app
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"io"
|
||||
"net/http"
|
||||
|
||||
"github.com/xanzy/go-gitlab"
|
||||
)
|
||||
|
||||
type ReviewerUpdateRequest struct {
|
||||
Ids []int `json:"ids"`
|
||||
}
|
||||
|
||||
type ReviewerUpdateResponse struct {
|
||||
SuccessResponse
|
||||
Reviewers []*gitlab.BasicUser `json:"reviewers"`
|
||||
}
|
||||
|
||||
type ReviewersRequestResponse struct {
|
||||
SuccessResponse
|
||||
Reviewers []int `json:"reviewers"`
|
||||
}
|
||||
|
||||
type MergeRequestUpdater interface {
|
||||
UpdateMergeRequest(pid interface{}, mergeRequest int, opt *gitlab.UpdateMergeRequestOptions, options ...gitlab.RequestOptionFunc) (*gitlab.MergeRequest, *gitlab.Response, error)
|
||||
}
|
||||
|
||||
type reviewerService struct {
|
||||
data
|
||||
client MergeRequestUpdater
|
||||
}
|
||||
|
||||
/* reviewersHandler adds or removes reviewers from an MR */
|
||||
func (a reviewerService) handler(w http.ResponseWriter, r *http.Request) {
|
||||
w.Header().Set("Content-Type", "application/json")
|
||||
if r.Method != http.MethodPut {
|
||||
w.Header().Set("Access-Control-Allow-Methods", http.MethodPut)
|
||||
handleError(w, InvalidRequestError{}, "Expected PUT", http.StatusMethodNotAllowed)
|
||||
return
|
||||
}
|
||||
|
||||
body, err := io.ReadAll(r.Body)
|
||||
if err != nil {
|
||||
handleError(w, err, "Could not read request body", http.StatusBadRequest)
|
||||
return
|
||||
}
|
||||
|
||||
defer r.Body.Close()
|
||||
var reviewerUpdateRequest ReviewerUpdateRequest
|
||||
err = json.Unmarshal(body, &reviewerUpdateRequest)
|
||||
|
||||
if err != nil {
|
||||
handleError(w, err, "Could not read JSON from request", http.StatusBadRequest)
|
||||
return
|
||||
}
|
||||
|
||||
mr, res, err := a.client.UpdateMergeRequest(a.projectInfo.ProjectId, a.projectInfo.MergeId, &gitlab.UpdateMergeRequestOptions{
|
||||
ReviewerIDs: &reviewerUpdateRequest.Ids,
|
||||
})
|
||||
|
||||
if err != nil {
|
||||
handleError(w, err, "Could not modify merge request reviewers", http.StatusInternalServerError)
|
||||
return
|
||||
}
|
||||
|
||||
if res.StatusCode >= 300 {
|
||||
handleError(w, GenericError{endpoint: "/mr/reviewer"}, "Could not modify merge request reviewers", res.StatusCode)
|
||||
return
|
||||
}
|
||||
|
||||
w.WriteHeader(http.StatusOK)
|
||||
response := ReviewerUpdateResponse{
|
||||
SuccessResponse: SuccessResponse{
|
||||
Message: "Reviewers updated",
|
||||
Status: http.StatusOK,
|
||||
},
|
||||
Reviewers: mr.Reviewers,
|
||||
}
|
||||
|
||||
err = json.NewEncoder(w).Encode(response)
|
||||
if err != nil {
|
||||
handleError(w, err, "Could not encode response", http.StatusInternalServerError)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user