Bugfixes, Etc. (#502)
* Fix: Jumping to renamed files (#484) * fix: prevent "cursor position outside buffer" error * fix: swap file_name and old_file_name in reviewer data `old_file_name` is not set to the empty string for un-renamed files anymore, because then we can remove the empty-line check in `comment_helpers.go` which was used to replace the empty string with the current file name anyway. * fix: add old_file_name to discussion root node data * fix: also consider old_file_name when jumping to the reviewer This fixes jumping to renamed files, however, may not work for comments that were created on renamed files with the previous version of `gitlab.nvim` as that version assigned the `file_name` and `old_file_name` incorrectly. * refactor: don't shadow variable * fix: check file_name or old_file_name based on which SHA comment belongs to * Fix: Store reviewer data before creating comment popup (#476) * Fix: Make publishing drafts more robust (#483) * Fix: Swap file_name and old_file_name in reviewer data (#485) * Feat: Enable toggling date format between relative and absolute (#491) * Fix: Add opts to help popup (#492) * Fix: Force start_line for jumping to diagnostic to be inside buffer (#494) * fix: redefine colors after reloading colorscheme (#500) * Fix: Use path instead of oldpath as fallback for unrenamed files (#496) * Fix: Use file_name when old_file_name is not set (#495) * fix(ci): fix lua tests (#501) * Proxy Support (#499) This is a #MINOR release. --------- Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me> Co-authored-by: Jonathan Duck <Duckbrain30@gmail.com>
This commit is contained in:
committed by
GitHub
parent
a260f648fe
commit
e29909cd10
@@ -110,6 +110,9 @@ end
|
||||
---@param line_number number Line number from the discussion node.
|
||||
---@param new_buffer boolean If true, jump to the NEW SHA.
|
||||
M.jump = function(file_name, old_file_name, line_number, new_buffer)
|
||||
-- Draft comments don't have `old_file_name` set
|
||||
old_file_name = old_file_name or file_name
|
||||
|
||||
if M.tabnr == nil then
|
||||
u.notify("Can't jump to Diffvew. Is it open?", vim.log.levels.ERROR)
|
||||
return
|
||||
@@ -240,7 +243,7 @@ end
|
||||
---@return string|nil
|
||||
M.get_current_file_oldpath = function()
|
||||
local file_data = M.get_current_file_data()
|
||||
return file_data and file_data.oldpath
|
||||
return file_data and file_data.oldpath or file_data.path
|
||||
end
|
||||
|
||||
---Tell whether current file is renamed or not
|
||||
|
||||
Reference in New Issue
Block a user