We weren't writing a 200 status code post-delete because Gitlab returns
a 204 (empty but successful) by default. I updated this logic to change
that and also to refresh the tree.

The collapsed state of the tree will be wiped out if you delete a
bottom-level discussion but that's okay for now, not a high priority
right now.
This commit is contained in:
Harrison (Harry) Cramer
2023-08-14 23:16:18 -04:00
committed by GitHub
parent 648e7a298b
commit d9a744300e
2 changed files with 14 additions and 4 deletions

View File

@@ -88,9 +88,9 @@ func DeleteComment(w http.ResponseWriter, r *http.Request) {
return return
} }
w.WriteHeader(res.StatusCode)
/* TODO: Check status code */ /* TODO: Check status code */
w.WriteHeader(http.StatusOK)
response := SuccessResponse{ response := SuccessResponse{
Message: "Comment deleted succesfully", Message: "Comment deleted succesfully",
Status: http.StatusOK, Status: http.StatusOK,

View File

@@ -40,7 +40,7 @@ M.confirm_create_comment = function(text)
local jsonTable = { line_number = current_line_number, file_name = relative_file_path, comment = text } local jsonTable = { line_number = current_line_number, file_name = relative_file_path, comment = text }
local json = vim.json.encode(jsonTable) local json = vim.json.encode(jsonTable)
job.run_job("comment", "POST", json, function() job.run_job("comment", "POST", json, function(data)
vim.notify("Comment created") vim.notify("Comment created")
discussions.refresh_tree() discussions.refresh_tree()
end) end)
@@ -93,7 +93,17 @@ M.send_deletion = function(item)
local json = vim.json.encode(jsonTable) local json = vim.json.encode(jsonTable)
job.run_job("comment", "DELETE", json, function(data) job.run_job("comment", "DELETE", json, function(data)
M.delete_node() vim.notify(data.message, vim.log.levels.INFO)
if not note_node.is_root then
state.tree:remove_node("-" .. note_id)
state.tree:render()
else
-- We are removing the root node of the discussion,
-- we need to move all the children around, the easiest way
-- to do this is to just re-render the whole tree 🤷
discussions.refresh_tree()
note_node:expand()
end
end) end)
end end
end end