Release 2.5.1 (#271)
* feat: Support for custom authentication provider functions (#270) * feat: Support for adding "draft" notes to the review, and publishing them, either individually or all at once. Addresses feature request #223. * feat: Lets users select + checkout a merge request directly within Neovim, without exiting to the terminal * fix: Checks that the remote feature branch exists and is up-to-date before creating a MR, starting a review, or opening the MR summary (#278) * docs: We require some state from Diffview, this shows how to load that state prior to installing w/ Packer. Fixes #94. This is a #MINOR release. --------- Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me> Co-authored-by: sunfuze <sunfuze.1989@gmail.com> Co-authored-by: Patrick Pichler <mail@patrickpichler.dev>
This commit is contained in:
committed by
GitHub
parent
f10c4ebb8f
commit
cf6ccddce3
@@ -23,7 +23,7 @@ func getInfoErr(pid interface{}, mergeRequest int, opt *gitlab.GetMergeRequestsO
|
||||
func TestInfoHandler(t *testing.T) {
|
||||
t.Run("Returns normal information", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodGet, "/mr/info", nil)
|
||||
server, _ := createRouterAndApi(fakeClient{getMergeRequestFn: getInfo})
|
||||
server, _ := createRouterAndApi(fakeClient{getMergeRequest: getInfo})
|
||||
data := serveRequest(t, server, request, InfoResponse{})
|
||||
assert(t, data.Info.Title, "Some Title")
|
||||
assert(t, data.SuccessResponse.Message, "Merge requests retrieved")
|
||||
@@ -32,21 +32,21 @@ func TestInfoHandler(t *testing.T) {
|
||||
|
||||
t.Run("Disallows non-GET method", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodPost, "/mr/info", nil)
|
||||
server, _ := createRouterAndApi(fakeClient{getMergeRequestFn: getInfo})
|
||||
server, _ := createRouterAndApi(fakeClient{getMergeRequest: getInfo})
|
||||
data := serveRequest(t, server, request, ErrorResponse{})
|
||||
checkBadMethod(t, *data, http.MethodGet)
|
||||
})
|
||||
|
||||
t.Run("Handles errors from Gitlab client", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodGet, "/mr/info", nil)
|
||||
server, _ := createRouterAndApi(fakeClient{getMergeRequestFn: getInfoErr})
|
||||
server, _ := createRouterAndApi(fakeClient{getMergeRequest: getInfoErr})
|
||||
data := serveRequest(t, server, request, ErrorResponse{})
|
||||
checkErrorFromGitlab(t, *data, "Could not get project info")
|
||||
})
|
||||
|
||||
t.Run("Handles non-200s from Gitlab client", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodGet, "/mr/info", nil)
|
||||
server, _ := createRouterAndApi(fakeClient{getMergeRequestFn: getInfoNon200})
|
||||
server, _ := createRouterAndApi(fakeClient{getMergeRequest: getInfoNon200})
|
||||
data := serveRequest(t, server, request, ErrorResponse{})
|
||||
checkNon200(t, *data, "Could not get project info", "/mr/info")
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user