Release 2.5.1 (#271)

* feat: Support for custom authentication provider functions (#270) * feat: Support for adding "draft" notes to the review, and publishing them, either individually or all at once. Addresses feature request #223. * feat: Lets users select + checkout a merge request directly within Neovim, without exiting to the terminal * fix: Checks that the remote feature branch exists and is up-to-date before creating a MR, starting a review, or opening the MR summary (#278) * docs: We require some state from Diffview, this shows how to load that state prior to installing w/ Packer. Fixes #94. This is a #MINOR release. --------- Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me> Co-authored-by: sunfuze <sunfuze.1989@gmail.com> Co-authored-by: Patrick Pichler <mail@patrickpichler.dev>
2024-04-22 16:56:27 -04:00
parent f10c4ebb8f
commit cf6ccddce3
42 changed files with 2830 additions and 1149 deletions
--- a/cmd/comment_helpers.go
+++ b/cmd/comment_helpers.go
@@ -0,0 +1,82 @@
+package main
+
+import (
+	"crypto/sha1"
+	"fmt"
+
+	"github.com/xanzy/go-gitlab"
+)
+
+/* LinePosition represents a position in a line range. Unlike the Gitlab struct, this does not contain LineCode with a sha1 of the filename */
+type LinePosition struct {
+	Type    string `json:"type"`
+	OldLine int    `json:"old_line"`
+	NewLine int    `json:"new_line"`
+}
+
+/* LineRange represents the range of a note. */
+type LineRange struct {
+	StartRange *LinePosition `json:"start"`
+	EndRange   *LinePosition `json:"end"`
+}
+
+/* PositionData represents the position of a comment or note (relative to a file diff) */
+type PositionData struct {
+	FileName       string     `json:"file_name"`
+	NewLine        *int       `json:"new_line,omitempty"`
+	OldLine        *int       `json:"old_line,omitempty"`
+	HeadCommitSHA  string     `json:"head_commit_sha"`
+	BaseCommitSHA  string     `json:"base_commit_sha"`
+	StartCommitSHA string     `json:"start_commit_sha"`
+	Type           string     `json:"type"`
+	LineRange      *LineRange `json:"line_range,omitempty"`
+}
+
+/* RequestWithPosition is an interface that abstracts the handling of position data for a comment or a draft comment */
+type RequestWithPosition interface {
+	GetPositionData() PositionData
+}
+
+/* buildCommentPosition takes a comment or draft comment request and builds the position data necessary for a location-based comment */
+func buildCommentPosition(commentWithPositionData RequestWithPosition) *gitlab.PositionOptions {
+	positionData := commentWithPositionData.GetPositionData()
+
+	opt := &gitlab.PositionOptions{
+		PositionType: &positionData.Type,
+		StartSHA:     &positionData.StartCommitSHA,
+		HeadSHA:      &positionData.HeadCommitSHA,
+		BaseSHA:      &positionData.BaseCommitSHA,
+		NewPath:      &positionData.FileName,
+		OldPath:      &positionData.FileName,
+		NewLine:      positionData.NewLine,
+		OldLine:      positionData.OldLine,
+	}
+
+	if positionData.LineRange != nil {
+		shaFormat := "%x_%d_%d"
+		startFilenameSha := fmt.Sprintf(
+			shaFormat,
+			sha1.Sum([]byte(positionData.FileName)),
+			positionData.LineRange.StartRange.OldLine,
+			positionData.LineRange.StartRange.NewLine,
+		)
+		endFilenameSha := fmt.Sprintf(
+			shaFormat,
+			sha1.Sum([]byte(positionData.FileName)),
+			positionData.LineRange.EndRange.OldLine,
+			positionData.LineRange.EndRange.NewLine,
+		)
+		opt.LineRange = &gitlab.LineRangeOptions{
+			Start: &gitlab.LinePositionOptions{
+				Type:     &positionData.LineRange.StartRange.Type,
+				LineCode: &startFilenameSha,
+			},
+			End: &gitlab.LinePositionOptions{
+				Type:     &positionData.LineRange.EndRange.Type,
+				LineCode: &endFilenameSha,
+			},
+		}
+	}
+
+	return opt
+}