2.0.0 (#196)

This MR is a #MAJOR breaking change to the plugin. While the plugin will continue to work for users with their existing settings, they will be informed of outdated configuration (diagnostics and signs have been simplified) the next time they open the reviewer.

Fix: Trim trailing slash from custom URLs
Update: .github/CONTRIBUTING.md, .github/ISSUE_TEMPLATE/bug_report.md
Feat: Improve discussion tree toggling (#192)
Fix: Toggle modified notes (#188)
Fix: Toggle discussion nodes correctly
Feat: Show Help keymap in discussion tree winbar
Fix: Enable toggling nodes from the note body
Fix: Enable toggling resolved status from child nodes
Fix: Only try to show emoji popup on note nodes
Feat: Add keymap for toggling tree type
Fix: Disable tree type toggling in Notes
Fix Multi Line Issues (Large Refactor) (#197)
Fix: Multi-line discussions. The calculation of a range for a multiline comment has been consolidated and moved into the location.lua file. This does not attempt to fix diagnostics.
Refactor: It refactors the discussions code to split hunk parsing and management into a separate module
Fix: Don't allow comments on modified buffers #194 by preventing comments on the reviewer when using --imply-local and when the working tree is dirty entirely.
Refactor: It introduces a new List class for data aggregation, filtering, etc.
Fix: It removes redundant API calls and refreshes from the discussion pane
Fix: Location provider (#198)
Fix: add nil check for Diffview performance issue (#199)
Fix: Switch Tabs During Comment Creation (#200)
Fix: Check if file is modified (#201)
Fix: Off-By-One Issue in Old SHA (#202)
Fix: Rebuild Diagnostics + Signs (#203)
Fix: Off-By-One Issue in New SHA (#205)
Fix: Reviewer Jumps to wrong location (#206)

BREAKING CHANGE: Changes configuration of diagnostics and signs in the setup call.

lua/gitlab/actions/discussions/tree.lua

@@ -81,7 +81,7 @@ end
 ---Build note header from note.
 ---@param note Note
 ---@return string
-local function build_note_header(note)
+M.build_note_header = function(note)
   return "@" .. note.author.username .. " " .. u.time_since(note.created_at)
 end
 
@@ -112,7 +112,7 @@ local function build_note_body(note, resolve_info)
       or state.settings.discussion_tree.unresolved
   end
 
-  local noteHeader = build_note_header(note) .. " " .. resolve_symbol
+  local noteHeader = M.build_note_header(note) .. " " .. resolve_symbol
 
   return noteHeader, text_nodes
 end
@@ -158,8 +158,9 @@ M.add_discussions_to_table = function(items, unlinked)
     local root_id
     local root_text_nodes = {}
     local resolvable = false
+    ---@type GitlabLineRange|nil
+    local range = nil
     local resolved = false
-    local undefined_type = false
     local root_new_line = nil
     local root_old_line = nil
     local root_url
@@ -175,16 +176,7 @@ M.add_discussions_to_table = function(items, unlinked)
         resolvable = note.resolvable
         resolved = note.resolved
         root_url = state.INFO.web_url .. "#note_" .. note.id
-
-        -- This appears to be a Gitlab 🐛 where the "type" is returned as an empty string in some cases
-        -- We link these comments to the old file by default
-        if
-          type(note.position) == "table"
-          and note.position.line_range ~= nil
-          and note.position.line_range.start.type == ""
-        then
-          undefined_type = true
-        end
+        range = (type(note.position) == "table" and note.position.line_range or nil)
       else -- Otherwise insert it as a child node...
         local note_node = M.build_note(note)
         table.insert(discussion_children, note_node)
@@ -194,6 +186,7 @@ M.add_discussions_to_table = function(items, unlinked)
     -- Creates the first node in the discussion, and attaches children
     local body = u.spread(root_text_nodes, discussion_children)
     local root_node = NuiTree.Node({
+      range = range,
       text = root_text,
       type = "note",
       is_root = true,
@@ -204,7 +197,6 @@ M.add_discussions_to_table = function(items, unlinked)
       old_line = root_old_line,
       resolvable = resolvable,
       resolved = resolved,
-      undefined_type = undefined_type,
       url = root_url,
     }, body)