acoolname/gitlab.nvim
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify Go Endpoints + Add Tests (#120)

Browse Source 
This MR represents a major refactor of the Go codebase, as well as introducing tests for the handlers. The MR also introduces an endpoint to shutdown or restart the Go server, which may be useful for clients who want to refresh the state of the plugin after checking out branches. Finally, this MR adds a contributing document for users who want to make feature changes.
This commit is contained in:
Harrison (Harry) Cramer
2023-12-04 10:15:07 -05:00
committed by GitHub
parent 10b0b596ae
commit 93fe3e8bd6
41 changed files with 1745 additions and 728 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
cmd/assignee.go
View File

@@ -22,13 +22,18 @@ type AssigneesRequestResponse struct {
Assignees []int `json:"assignees"`
}
func AssigneesHandler(w http.ResponseWriter, r *http.Request) {
c := r.Context().Value("client").(Client)
/* assigneesHandler adds or removes assignees from a merge request. */
func (a *api) assigneesHandler(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
if r.Method != http.MethodPut {
w.Header().Set("Access-Control-Allow-Methods", http.MethodPut)
handleError(w, InvalidRequestError{}, "Expected PUT", http.StatusMethodNotAllowed)
return
}
body, err := io.ReadAll(r.Body)
if err != nil {
c.handleError(w, err, "Could not read request body", http.StatusBadRequest)
handleError(w, err, "Could not read request body", http.StatusBadRequest)
return
}
@@ -37,26 +42,25 @@ func AssigneesHandler(w http.ResponseWriter, r *http.Request) {
err = json.Unmarshal(body, &assigneeUpdateRequest)
if err != nil {
c.handleError(w, err, "Could not read JSON from request", http.StatusBadRequest)
handleError(w, err, "Could not read JSON from request", http.StatusBadRequest)
return
}
mr, res, err := c.git.MergeRequests.UpdateMergeRequest(c.projectId, c.mergeId, &gitlab.UpdateMergeRequestOptions{
mr, res, err := a.client.UpdateMergeRequest(a.projectInfo.ProjectId, a.projectInfo.MergeId, &gitlab.UpdateMergeRequestOptions{
AssigneeIDs: &assigneeUpdateRequest.Ids,
})
if err != nil {
c.handleError(w, err, "Could not modify merge request assignees", http.StatusBadRequest)
handleError(w, err, "Could not modify merge request assignees", http.StatusInternalServerError)
return
}
if res.StatusCode != http.StatusOK {
c.handleError(w, err, "Could not modify merge request assignees", http.StatusBadRequest)
if res.StatusCode >= 300 {
handleError(w, GenericError{endpoint: "/mr/assignee"}, "Could not modify merge request assignees", res.StatusCode)
return
}
w.WriteHeader(http.StatusOK)
response := AssigneeUpdateResponse{
SuccessResponse: SuccessResponse{
Message: "Assignees updated",
@@ -67,6 +71,6 @@ func AssigneesHandler(w http.ResponseWriter, r *http.Request) {
err = json.NewEncoder(w).Encode(response)
if err != nil {
c.handleError(w, err, "Could not encode response", http.StatusInternalServerError)
handleError(w, err, "Could not encode response", http.StatusInternalServerError)
}
}