acoolname/gitlab.nvim
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add Filtering, HealthCheck, Better Tests (#350)

Browse Source 
feat: add filtering when choosing merge requests (#346)
feat: Add healthcheck (#345)
refactor: Move to gomock (#349)
feat: Makes the remote of the plugin configurable (#348)

This is a #MINOR release.
This commit is contained in:
Harrison (Harry) Cramer
2024-08-23 14:01:59 -04:00
committed by GitHub
parent aa5d3c1f52
commit 4ae623cd65
61 changed files with 2174 additions and 1082 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
cmd/job_test.go
View File

@@ -2,53 +2,58 @@ package main
import (
"bytes"
"errors"
"net/http"
"testing"
"github.com/xanzy/go-gitlab"
mock_main "gitlab.com/harrisoncramer/gitlab.nvim/cmd/mocks"
)
func getTraceFile(pid interface{}, jobID int, options ...gitlab.RequestOptionFunc) (*bytes.Reader, *gitlab.Response, error) {
return bytes.NewReader([]byte("Some data")), makeResponse(http.StatusOK), nil
}
func getTraceFileErr(pid interface{}, jobID int, options ...gitlab.RequestOptionFunc) (*bytes.Reader, *gitlab.Response, error) {
return nil, nil, errors.New("Some error from Gitlab")
}
func getTraceFileNon200(pid interface{}, jobID int, options ...gitlab.RequestOptionFunc) (*bytes.Reader, *gitlab.Response, error) {
return nil, makeResponse(http.StatusSeeOther), nil
}
var jobId = 0
func TestJobHandler(t *testing.T) {
t.Run("Should read a job trace file", func(t *testing.T) {
client := mock_main.NewMockClient(t)
client.EXPECT().GetTraceFile("", jobId).Return(bytes.NewReader([]byte("Some data")), makeResponse(http.StatusOK), nil)
request := makeRequest(t, http.MethodGet, "/job", JobTraceRequest{})
server, _ := createRouterAndApi(fakeClient{getTraceFile: getTraceFile})
server, _ := CreateRouterAndApi(client)
data := serveRequest(t, server, request, JobTraceResponse{})
assert(t, data.SuccessResponse.Message, "Log file read")
assert(t, data.SuccessResponse.Status, http.StatusOK)
assert(t, data.File, "Some data")
})
t.Run("Disallows non-GET methods", func(t *testing.T) {
client := mock_main.NewMockClient(t)
client.EXPECT().GetTraceFile("", jobId).Return(bytes.NewReader([]byte("Some data")), makeResponse(http.StatusOK), nil)
request := makeRequest(t, http.MethodPost, "/job", JobTraceRequest{})
server, _ := createRouterAndApi(fakeClient{getTraceFile: getTraceFile})
server, _ := CreateRouterAndApi(client)
data := serveRequest(t, server, request, ErrorResponse{})
checkBadMethod(t, *data, http.MethodGet)
})
t.Run("Should handle errors from Gitlab", func(t *testing.T) {
client := mock_main.NewMockClient(t)
client.EXPECT().GetTraceFile("", jobId).Return(nil, nil, errorFromGitlab)
request := makeRequest(t, http.MethodGet, "/job", JobTraceRequest{})
server, _ := createRouterAndApi(fakeClient{getTraceFile: getTraceFileErr})
server, _ := CreateRouterAndApi(client)
data := serveRequest(t, server, request, ErrorResponse{})
checkErrorFromGitlab(t, *data, "Could not get trace file for job")
})
t.Run("Should handle non-200s", func(t *testing.T) {
t.Run("Should handle non-2jobIdjobIds", func(t *testing.T) {
client := mock_main.NewMockClient(t)
client.EXPECT().GetTraceFile("", jobId).Return(nil, makeResponse(http.StatusSeeOther), nil)
request := makeRequest(t, http.MethodGet, "/job", JobTraceRequest{})
server, _ := createRouterAndApi(fakeClient{getTraceFile: getTraceFileNon200})
server, _ := CreateRouterAndApi(client)
data := serveRequest(t, server, request, ErrorResponse{})
checkNon200(t, *data, "Could not get trace file for job", "/job")
})
}