acoolname/gitlab.nvim
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug Fixes (#382)

Browse Source 
* fix: error messages and run all tests (#381)
* feat: Automatically open fold under cursor (#380)
* fix: discussion ID is not required (#383)

This is a #PATCH release.

---------

Co-authored-by: George Kontridze <george.kontridze@gmail.com>
Co-authored-by: Jakub F. Bortlík <jakub.bortlik@proton.me>
This commit is contained in:
Harrison (Harry) Cramer
2024-09-26 10:11:48 -04:00
committed by GitHub
parent 5c9b88db4f
commit 38bde8a0e4
5 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/app/draft_notes.go
View File

@@ -90,7 +90,7 @@ func (a draftNoteService) listDraftNotes(w http.ResponseWriter, r *http.Request)
type PostDraftNoteRequest struct { type PostDraftNoteRequest struct {
Comment string `json:"comment" validate:"required"` Comment string `json:"comment" validate:"required"`
DiscussionId string `json:"discussion_id,omitempty" validate:"required"` DiscussionId string `json:"discussion_id,omitempty"`
PositionData // TODO: How to add validations to data from external package??? PositionData // TODO: How to add validations to data from external package???
} }

4
cmd/app/git/git_test.go
View File

@@ -198,7 +198,7 @@ func TestExtractGitInfo_FailToGetProjectRemoteUrl(t *testing.T) {
tC := FailTestCase{ tC := FailTestCase{
desc: "Error returned by function to get the project remote url", desc: "Error returned by function to get the project remote url",
errMsg: "Some error", errMsg: "Some error",
expectedErr: "Could not get project Url: Some error", expectedErr: "could not get project Url: Some error",
} }
t.Run(tC.desc, func(t *testing.T) { t.Run(tC.desc, func(t *testing.T) {
g := failingUrlManager{ g := failingUrlManager{
@@ -227,7 +227,7 @@ func TestExtractGitInfo_FailToGetCurrentBranchName(t *testing.T) {
tC := FailTestCase{ tC := FailTestCase{
desc: "Error returned by function to get the project remote url", desc: "Error returned by function to get the project remote url",
errMsg: "Some error", errMsg: "Some error",
expectedErr: "Failed to get current branch: Some error", expectedErr: "failed to get current branch: Some error",
} }
t.Run(tC.desc, func(t *testing.T) { t.Run(tC.desc, func(t *testing.T) {
g := failingBranchManager{ g := failingBranchManager{

2
lua/gitlab/reviewer/init.lua
View File

@@ -145,6 +145,8 @@ M.jump = function(file_name, line_number, new_buffer)
line_number = number_of_lines line_number = number_of_lines
end end
vim.api.nvim_win_set_cursor(0, { line_number, 0 }) vim.api.nvim_win_set_cursor(0, { line_number, 0 })
u.open_fold_under_cursor()
vim.cmd("normal! zz")
end end
---Get the data from diffview, such as line information and file name. May be used by ---Get the data from diffview, such as line information and file name. May be used by

6
lua/gitlab/utils/init.lua
View File

@@ -752,4 +752,10 @@ M.get_nested_field = function(table, field)
end end
end end
M.open_fold_under_cursor = function()
if vim.fn.foldclosed(vim.fn.line(".")) > -1 then
vim.cmd("normal! zo")
end
end
return M return M

4
makefile
View File

@@ -4,10 +4,10 @@ PROJECTNAME=$(shell basename "$(PWD)")
## compile: build golang project ## compile: build golang project
compile: compile:
@cd cmd && go build -o bin && mv bin ../bin @go build -o bin ./cmd
## test: run golang project tests ## test: run golang project tests
test: test:
@cd cmd/app && go test @go test -v ./...
.PHONY: help .PHONY: help
all: help all: help