Feat: Create Merge Request (#149)
- Adds the ability to create MRs to the plugin - Adds the ability to jump to specific discussions/notes in the browser - Fixes stale icons - Adds debug keybinding for discussion tree for developers
This commit is contained in:
committed by
GitHub
parent
35f0bc16a5
commit
37a53842d0
@@ -36,7 +36,7 @@ func withMockFileReader(a *api) error {
|
||||
|
||||
func TestAttachmentHandler(t *testing.T) {
|
||||
t.Run("Returns 200-status response after upload", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodPost, "/mr/attachment", AttachmentRequest{FilePath: "some_file_path", FileName: "some_file_name"})
|
||||
request := makeRequest(t, http.MethodPost, "/attachment", AttachmentRequest{FilePath: "some_file_path", FileName: "some_file_name"})
|
||||
router, _ := createRouterAndApi(fakeClient{uploadFile: uploadFile}, withMockFileReader)
|
||||
data := serveRequest(t, router, request, AttachmentResponse{})
|
||||
assert(t, data.SuccessResponse.Status, http.StatusOK)
|
||||
@@ -44,23 +44,23 @@ func TestAttachmentHandler(t *testing.T) {
|
||||
})
|
||||
|
||||
t.Run("Disallows non-POST method", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodPut, "/mr/attachment", AttachmentRequest{FilePath: "some_file_path", FileName: "some_file_name"})
|
||||
request := makeRequest(t, http.MethodPut, "/attachment", AttachmentRequest{FilePath: "some_file_path", FileName: "some_file_name"})
|
||||
router, _ := createRouterAndApi(fakeClient{uploadFile: uploadFile}, withMockFileReader)
|
||||
data := serveRequest(t, router, request, ErrorResponse{})
|
||||
checkBadMethod(t, *data, http.MethodPost)
|
||||
})
|
||||
|
||||
t.Run("Handles errors from Gitlab client", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodPost, "/mr/attachment", AttachmentRequest{FilePath: "some_file_path", FileName: "some_file_name"})
|
||||
request := makeRequest(t, http.MethodPost, "/attachment", AttachmentRequest{FilePath: "some_file_path", FileName: "some_file_name"})
|
||||
router, _ := createRouterAndApi(fakeClient{uploadFile: uploadFileErr}, withMockFileReader)
|
||||
data := serveRequest(t, router, request, ErrorResponse{})
|
||||
checkErrorFromGitlab(t, *data, "Could not upload some_file_name to Gitlab")
|
||||
})
|
||||
|
||||
t.Run("Handles non-200s from Gitlab client", func(t *testing.T) {
|
||||
request := makeRequest(t, http.MethodPost, "/mr/attachment", AttachmentRequest{FilePath: "some_file_path", FileName: "some_file_name"})
|
||||
request := makeRequest(t, http.MethodPost, "/attachment", AttachmentRequest{FilePath: "some_file_path", FileName: "some_file_name"})
|
||||
router, _ := createRouterAndApi(fakeClient{uploadFile: uploadFileNon200}, withMockFileReader)
|
||||
data := serveRequest(t, router, request, ErrorResponse{})
|
||||
checkNon200(t, *data, "Could not upload some_file_name to Gitlab", "/mr/attachment")
|
||||
checkNon200(t, *data, "Could not upload some_file_name to Gitlab", "/attachment")
|
||||
})
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user