acoolname/gitlab.nvim
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fixed sign/diagnostic filtering (#150)

Browse Source 
This was a small diagnostics/signs regression introduced by #147.

We were filtering the diagnostics and discussions but then not actually using the filtered data. Facepalm.
This commit is contained in:
Harrison (Harry) Cramer
2023-12-18 17:00:04 -05:00
committed by GitHub
parent 571173c881
commit 35f0bc16a5
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lua/gitlab/actions/discussions/signs.lua
View File

@@ -20,13 +20,13 @@ end
---string for sign name and sign group ( currently there is only one sign needed) ---string for sign name and sign group ( currently there is only one sign needed)
---@param discussions Discussion[] ---@param discussions Discussion[]
M.refresh_signs = function(discussions) M.refresh_signs = function(discussions)
local diagnostics = M.filter_discussions_for_signs_and_diagnostics(discussions) local filtered_discussions = M.filter_discussions_for_signs_and_diagnostics(discussions)
if diagnostics == nil then if filtered_discussions == nil then
vim.diagnostic.reset(diagnostics_namespace) vim.diagnostic.reset(diagnostics_namespace)
return return
end end
local new_signs, old_signs, error = M.parse_signs_from_discussions(discussions) local new_signs, old_signs, error = M.parse_signs_from_discussions(filtered_discussions)
if error ~= nil then if error ~= nil then
vim.notify(error, vim.log.levels.ERROR) vim.notify(error, vim.log.levels.ERROR)
return return
@@ -42,13 +42,13 @@ end
M.refresh_diagnostics = function(discussions) M.refresh_diagnostics = function(discussions)
-- Keep in mind that diagnostic line numbers use 0-based indexing while line numbers use -- Keep in mind that diagnostic line numbers use 0-based indexing while line numbers use
-- 1-based indexing -- 1-based indexing
local diagnostics = M.filter_discussions_for_signs_and_diagnostics(discussions) local filtered_discussions = M.filter_discussions_for_signs_and_diagnostics(discussions)
if diagnostics == nil then if filtered_discussions == nil then
vim.diagnostic.reset(diagnostics_namespace) vim.diagnostic.reset(diagnostics_namespace)
return return
end end
local new_diagnostics, old_diagnostics = M.parse_diagnostics_from_discussions(discussions) local new_diagnostics, old_diagnostics = M.parse_diagnostics_from_discussions(filtered_discussions)
vim.diagnostic.reset(diagnostics_namespace) vim.diagnostic.reset(diagnostics_namespace)
reviewer.set_diagnostics( reviewer.set_diagnostics(