acoolname/gitlab.nvim
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: date fixes; go middleware refactors; regex fixes; etc (#368)

Browse Source 
fix: format of date when MR was closed or merged (#367)
refactor: Add Payload Validators + Middleware In Go Code (#366)
fix: Add better checks for leaving comments (#369)
fix: regex support for http credentials embedded in remote url (#372)
fix: Comment on single line selects two lines (#371)

This is a #PATCH release.
This commit is contained in:
Harrison (Harry) Cramer
2024-09-14 16:53:00 -04:00
committed by GitHub
parent f1faf603b0
commit 22bfd0c83e
61 changed files with 1527 additions and 1284 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
cmd/app/approve_test.go
View File

@@ -23,33 +23,36 @@ func TestApproveHandler(t *testing.T) {
t.Run("Approves merge request", func(t *testing.T) {
request := makeRequest(t, http.MethodPost, "/mr/approve", nil)
client := fakeApproverClient{}
svc := mergeRequestApproverService{testProjectData, client}
svc := middleware(
mergeRequestApproverService{testProjectData, client},
withMr(testProjectData, fakeMergeRequestLister{}),
withMethodCheck(http.MethodPost),
)
data := getSuccessData(t, svc, request)
assert(t, data.Message, "Approved MR")
assert(t, data.Status, http.StatusOK)
})
t.Run("Disallows non-POST method", func(t *testing.T) {
request := makeRequest(t, http.MethodGet, "/mr/approve", nil)
client := fakeApproverClient{}
svc := mergeRequestApproverService{testProjectData, client}
data := getFailData(t, svc, request)
checkBadMethod(t, data, http.MethodPost)
})
t.Run("Handles errors from Gitlab client", func(t *testing.T) {
request := makeRequest(t, http.MethodPost, "/mr/approve", nil)
client := fakeApproverClient{testBase{errFromGitlab: true}}
svc := mergeRequestApproverService{testProjectData, client}
data := getFailData(t, svc, request)
svc := middleware(
mergeRequestApproverService{testProjectData, client},
withMr(testProjectData, fakeMergeRequestLister{}),
withMethodCheck(http.MethodPost),
)
data, _ := getFailData(t, svc, request)
checkErrorFromGitlab(t, data, "Could not approve merge request")
})
t.Run("Handles non-200s from Gitlab client", func(t *testing.T) {
request := makeRequest(t, http.MethodPost, "/mr/approve", nil)
client := fakeApproverClient{testBase{status: http.StatusSeeOther}}
svc := mergeRequestApproverService{testProjectData, client}
data := getFailData(t, svc, request)
svc := middleware(
mergeRequestApproverService{testProjectData, client},
withMr(testProjectData, fakeMergeRequestLister{}),
withMethodCheck(http.MethodPost),
)
data, _ := getFailData(t, svc, request)
checkNon200(t, data, "Could not approve merge request", "/mr/approve")
})
}